Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Commit #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Paa1006
Copy link

@Paa1006 Paa1006 commented Dec 9, 2015

I think I have everything working as it should. I am not sure how you
wanted me to use the Test file you gave us.

I think I have everything working as it should. I am not sure how you
wanted me to use the Test file you gave us.
@ninjapanzer
Copy link
Member

We are half way through the final and this was submitted three hours ago.

🍀

#### This file describes handfuls of dice you need to calculate
#### Legend <sides><type> eg. d6 fudge dice look like 6:fudge
#### 20 numbered - 20:numbered
#### Loaded 10 sided with 6 loaded - 10:loaded:6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be filtering this out when your code reads the file. Assume that you are going to keep getting files like this on an interval. Do you want to have to hand edit each one before you can run it against your program?

@Paa1006
Copy link
Author

Paa1006 commented Dec 14, 2015

I do my best work at the last minute! You are right, I should have made the program filter out those comments. I was having trouble getting everything to work, and took the easy way out. Looking back I'd just have to ignore the lines that start with "-####". I'll have to play around with that test a bit to figure out how to implement it there.

@ztmurphy21
Copy link
Member

Try creating an if statement to avoid the ####, also your code is very easy to follow along with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants