No changes #9
Open
No changes #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No changes were made to this file yet.
Here are the new changes.
Final version of Assignment 7.
| public void dropDice() { | ||
| for (int i = 0; i < PANEL_COUNT; i++) { | ||
| for (int j = 0; j < dice.size(); j++) { | ||
| Die temp = dice.get(j); |
There was a problem hiding this comment.
love it. temp isn't a great name but I like you pulling it into a variable. You could also have done
for(Dice item : this.dice){
item.roll();
}
|
|
Looking good
| @@ -30,7 +38,7 @@ public static int test_oneD6(){ | |||
| Die die = new Die(6); | |||
| die.roll(); | |||
| int dieValue = die.value(); | |||
| if(dieValue >= 1 && dieValue <= 6){ | |||
| if(dieValue < 1 || dieValue > 6){ | |||
| return -1; // Means the die value is outside its bounds for a d6 | |||
There was a problem hiding this comment.
Though I just changed the comment, I think this makes more sense.
This reverts commit 8bc6393.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No changes were made to this file yet.