1st Commit #14
Open
1st Commit #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Help, after blatantly cheating, I still cannot get the DiceTower to work.
| for(int p =0; p <PANELS; p++){ | ||
| this.dice.get(i).roll(); | ||
| } | ||
| trayValue += this.dice.get(i).value(); |
There was a problem hiding this comment.
this is a partial violation of the Single Responsibility Principle.
This method should just deal with dropping the dice
tray value should handle reading the values of the dice there. This a good idea because it saves you a loop though
I tried again less cheating. Just needed some help with the constructors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Help, after blatantly cheating, I still cannot get the DiceTower to
work.