-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gcode class #52
Gcode class #52
Conversation
- the GCode Processor was improved in many way - usage of more dicionary methods
- g_code was changed to an array[dictionary] format - this enables a better handling of the g_code inside and outside of the processor
- adjusting test method
- test class was adapted to dictionary format
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
==========================================
+ Coverage 85.27% 86.96% +1.68%
==========================================
Files 15 15
Lines 951 951
==========================================
+ Hits 811 827 +16
+ Misses 140 124 -16 ☔ View full report in Codecov by Sentry. |
- adding empty line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is completely unclear to me what the changes proposed are meant to achieve.
It seems that some are just renaming variables while other change lists to dict etc...
Is it just a refractoring that does not change the behavior of the code or is this pull request fixing any bugs?
Please fill out the pull request template to clarify
Hello @liquidcronos, |
Closing pull-request due to it beeing outdated. |
Description
The following changes have been made to the GCodeProcessor:
g_code
.g_code
has been updated to an array dictionary format ([{G: 1, X: 2.0, Y: 1.0}, {G: 1, X: 1.0}, ...]
).read_g_code()
method has been modified to convert the input to this new format.Motivation and Context
Change Number 1 was implemented to enhance the overall code style.
Changes Number 1 and 3 were made to improve the handling of
g_code
. Utilizing dictionaries makes it more convenient to manage information within the G-code.How has this been tested?
The changes have been thoroughly tested using the test method. The modifications are isolated and do not impact other areas of the code.
Screenshots (if appropriate):
Types of changes
Checklist: