-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add some typings for message api #290
Conversation
Codecov Report
@@ Coverage Diff @@
## master #290 +/- ##
=======================================
Coverage 68.31% 68.31%
=======================================
Files 25 25
Lines 928 928
=======================================
Hits 634 634
Misses 294 294 Continue to review full report at Codecov.
|
@jin60641 this breaks backwards compatibility for Verify. Can you please switch back the Verify responses and add a TODO note to change them when we release a new major version? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switch back the Verify namespacing.
I switch back the Verify api's namesapcing and add TODO comment on top of file. |
Any updates on this? |
I will evaluate this later this week along with #299 and get these added in. Thanks for your patience. |
Codecov Report
@@ Coverage Diff @@
## master #290 +/- ##
===========================================
+ Coverage 68.31% 90.44% +22.12%
===========================================
Files 25 25
Lines 928 827 -101
===========================================
+ Hits 634 748 +114
+ Misses 294 79 -215
Continue to review full report at Codecov.
|
I pulled these in for now and will start a larger change for v2.9. Thanks for the contribution. If you want to help out with others, I will be creating a new branch |
#278
It will support Message API's sendSms method
reference
MessageRequestResponseStatusCode
MessageRequestResponseSuccess, MessageError, MessageRequestResponse, SendSmsOptions, SendSms, Message