Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some typings for message api #290

Merged
merged 3 commits into from
Jul 23, 2020
Merged

Conversation

jin60641
Copy link

@jin60641 jin60641 commented Mar 2, 2020

@codecov-io
Copy link

codecov-io commented Mar 2, 2020

Codecov Report

Merging #290 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #290   +/-   ##
=======================================
  Coverage   68.31%   68.31%           
=======================================
  Files          25       25           
  Lines         928      928           
=======================================
  Hits          634      634           
  Misses        294      294

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d250bef...8447556. Read the comment docs.

@AlexLakatos AlexLakatos changed the base branch from master to beta March 2, 2020 09:39
@AlexLakatos AlexLakatos changed the base branch from beta to master March 2, 2020 09:40
@AlexLakatos
Copy link
Contributor

@jin60641 this breaks backwards compatibility for Verify. Can you please switch back the Verify responses and add a TODO note to change them when we release a new major version?

@AlexLakatos AlexLakatos self-requested a review March 2, 2020 09:43
Copy link
Contributor

@AlexLakatos AlexLakatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switch back the Verify namespacing.

@jin60641
Copy link
Author

jin60641 commented Mar 3, 2020

@jin60641 this breaks backwards compatibility for Verify. Can you please switch back the Verify responses and add a TODO note to change them when we release a new major version?

I switch back the Verify api's namesapcing and add TODO comment on top of file.
Thanks

@jin60641 jin60641 requested a review from AlexLakatos March 3, 2020 09:54
@AlexLakatos AlexLakatos removed their request for review July 3, 2020 15:48
@Coooi
Copy link

Coooi commented Jul 11, 2020

Any updates on this?
I really looking forward to it.

@kellyjandrews
Copy link
Contributor

I will evaluate this later this week along with #299 and get these added in. Thanks for your patience.

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2020

Codecov Report

Merging #290 into master will increase coverage by 22.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #290       +/-   ##
===========================================
+ Coverage   68.31%   90.44%   +22.12%     
===========================================
  Files          25       25               
  Lines         928      827      -101     
===========================================
+ Hits          634      748      +114     
+ Misses        294       79      -215     
Impacted Files Coverage Δ
src/Message.js 82.35% <0.00%> (-17.65%) ⬇️
src/Voice.js 95.00% <0.00%> (-5.00%) ⬇️
src/Redact.js 92.85% <0.00%> (-1.27%) ⬇️
src/Media.js 92.30% <0.00%> (-0.55%) ⬇️
src/App.js 100.00% <0.00%> (ø)
src/Utils.js 100.00% <0.00%> (ø)
src/Number.js 100.00% <0.00%> (ø)
src/Verify.js 100.00% <0.00%> (ø)
src/Account.js 100.00% <0.00%> (ø)
src/Conversion.js 100.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d250bef...180d146. Read the comment docs.

@kellyjandrews kellyjandrews added this to the v 2.9.0 milestone Jul 23, 2020
@kellyjandrews kellyjandrews merged commit 0aeb3a2 into Vonage:master Jul 23, 2020
@kellyjandrews
Copy link
Contributor

I pulled these in for now and will start a larger change for v2.9. Thanks for the contribution.

If you want to help out with others, I will be creating a new branch typing-updates to work towards a more complete set of types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants