Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add useDashboardTimeRange hook #50

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Conversation

asimonok
Copy link
Collaborator

No description provided.

@asimonok asimonok requested a review from mikhail-vl July 10, 2024 13:10
@asimonok asimonok self-assigned this Jul 10, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 75.32%. Comparing base (6838e64) to head (604dd93).

Files Patch % Lines
...ages/components/src/hooks/useDashboardTimeRange.ts 27.27% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
- Coverage   75.59%   75.32%   -0.27%     
==========================================
  Files          58       59       +1     
  Lines        1897     1909      +12     
  Branches      494      480      -14     
==========================================
+ Hits         1434     1438       +4     
- Misses        404      468      +64     
+ Partials       59        3      -56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Jul 10, 2024
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mikhail-vl mikhail-vl added this to the Components 2.7.0 milestone Jul 10, 2024
@mikhail-vl mikhail-vl merged commit 818f9e5 into main Jul 10, 2024
1 check passed
@mikhail-vl mikhail-vl deleted the feat/add-dashboard-time-range-hook branch July 10, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants