Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uninstallation steps for root certificate #202

Closed
wants to merge 3 commits into from

Conversation

qaisjp
Copy link

@qaisjp qaisjp commented Dec 8, 2024

I couldn't get HDR working in the end, so I decided to uninstall VDD and I noticed there was no undo step for the batch script.

Tbh, we could probably write a script for this!

(If you're wondering why: apparently Moonlight says my AMD RX 5700XT GPU is incompatible with HDR streaming? Seems false according to Google but I'm giving up on this for now.)

@itsmikethetech
Copy link
Member

This is somewhat useful information, but the certificate generally doesn't need to be removed to remove the driver from your system. It should just be uninstalled normally using the Device Manager. Will check with the team on adding the PR/info though, as it may still be useful. Thanks!

Updated with instructions on trusted publisher and switched it to local computer from users. And moved it out of easy uninstall to its own section
bud3699
bud3699 previously approved these changes Dec 15, 2024
Copy link
Collaborator

@bud3699 bud3699 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, Changed it to local instead of user and publisher, This is fine with me, moved it to its own section with title optional. Even though this obsolete soon

@bud3699 bud3699 dismissed their stale review December 15, 2024 10:05

Actually, probably pointless now.. I'll leave it in pr's for now incase anything changes

Comment on lines +80 to +82
5. In the sidebar, expand `Trusted Publishers` -> `Certificates` folder.
6. Scroll to the bottom, until you see "Virtual Display Driver".
7. Right click "Virtual Display Driver" and hit "Delete". In the warning that appears, choose "Yes".
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice, I missed this bit!

@qaisjp
Copy link
Author

qaisjp commented Dec 21, 2024

The certificate generally doesn't need to be removed to remove the driver from your system.

@itsmikethetech True! But ideally the uninstallation process would restore the original state prior to following installation, minus any custom configuration; which is why I thought it was worth including this info.

Even though this obsolete soon

Oh, why is it obsolete now @bud3699?

@itsmikethetech
Copy link
Member

The certificate generally doesn't need to be removed to remove the driver from your system.

@itsmikethetech True! But ideally the uninstallation process would restore the original state prior to following installation, minus any custom configuration; which is why I thought it was worth including this info.

Even though this obsolete soon

Oh, why is it obsolete now @bud3699?

To drop in with some info, we'll be moving to a real signed certificate in the next release, so no local certificate inclusion will be necessary. :)

@itsmikethetech
Copy link
Member

itsmikethetech commented Dec 24, 2024

This is now obsolete as we have a signed certificate.

Edit by bud:
but it is in the wiki if you want to

@qaisjp
Copy link
Author

qaisjp commented Dec 27, 2024

Oh, congrats on the signed cert!

@qaisjp qaisjp deleted the patch-1 branch December 27, 2024 00:46
@bud3699
Copy link
Collaborator

bud3699 commented Dec 27, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants