vine: allow returns with no expression #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjjfvi
reviewed
Oct 24, 2024
vine/src/compile/build_stages.rs
Outdated
| ExprKind::Return(r) => self.lower_return(r), | ||
| ExprKind::Return(None) => { | ||
| let unit = Expr { span: Span::NONE, kind: ExprKind::Tuple(vec![]) }; | ||
| self.lower_return(&unit) |
There was a problem hiding this comment.
I think it would be cleaner for lower_return to take an Option<Expr> and just not write to the local if it's None
There was a problem hiding this comment.
woah didn't expect that to work. Right now is it undefined behaviour to assign the result of function that returns nothing to a var?
There was a problem hiding this comment.
no, it's just that uninitialized variables are represented with an eraser node, which is the same as an empty tuple
There was a problem hiding this comment.
or, one can think of it as every variable being initialized as an empty tuple
Co-authored-by: T6 <[email protected]>
tjjfvi
approved these changes
Oct 24, 2024
tjjfvi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be merged before #72
Addresses a nice to have from #66