Skip to content

Commit

Permalink
Merge pull request Shopify#531 from Shopify/print-hidden-important
Browse files Browse the repository at this point in the history
Use `!important` in print-hidden mixin
  • Loading branch information
nickjs authored Nov 5, 2018
2 parents b130e68 + 03f44c3 commit f6f8107
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions UNRELEASED.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ The autocomplete component is an input field that provides selectable suggestion
- Fixed `Portal` rendering by using `componentDidMount` lifecycle hook as opposed to `componentWillMount`;
- Fixed an issue where clicking a `Link` without a `url` in a form would implicitly submit the form. `Link` can no longer submit forms. Use `<Button submit>` instead.
- Renamed the `Keys` enum to align with Shopify naming standards. It is now singular and the properties are in PascalCase. Replace `import {Keys} from '@shopify/polaris'` with `import {Key} from '@shopify/polaris'` and change the casing of the properties, e.g. replace `Keys.DOWN_ARROW` with `Key.DownArrow`
- Added !important to `display: none` in `@print-hidden` mixin

#### Embedded apps

Expand Down
3 changes: 2 additions & 1 deletion src/styles/shared/typography.scss
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ $typography-condensed: em(640px);

@mixin print-hidden {
@media print {
display: none;
// stylelint-disable-next-line declaration-no-important
display: none !important;
}
}

0 comments on commit f6f8107

Please sign in to comment.