Skip to content

Commit

Permalink
Enable color contrast test in pa11y (Shopify#1645)
Browse files Browse the repository at this point in the history
* Enable colour contrast failures
  • Loading branch information
Alex Page authored Jun 6, 2019
1 parent aa99cbb commit 7ddc216
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
1 change: 1 addition & 0 deletions UNRELEASED.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f

### Code quality

- Enabled the color contrast test in pa11y ([#1645](https://github.com/Shopify/polaris-react/pull/1645))
- Combined jsdocs in `Icon` for the `untrusted` prop ([#1607](https://github.com/Shopify/polaris-react/pull/1607))

### Deprecations
Expand Down
2 changes: 0 additions & 2 deletions scripts/pa11y.js
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,6 @@ async function runPa11y() {
// Missing lang attribute on <html> tag
// Storybook does not include this property so ignore it
'WCAG2AA.Principle3.Guideline3_1.3_1_1.H57.2',
// Color contrast failures
'WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail',
],
});
result.exampleID = queryString;
Expand Down
6 changes: 3 additions & 3 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1405,9 +1405,9 @@
integrity sha512-+nB2rthx6vS8vlJms5unGbThwrdGXAPMCD2PoQG/Eq5uQU1EmhkVOIFaEK7AS62J2m+HaqbLw/zrlbBkZHZUrQ==

"@shopify/polaris-tokens@^2.5.0":
version "2.5.0"
resolved "https://registry.yarnpkg.com/@shopify/polaris-tokens/-/polaris-tokens-2.5.0.tgz#3efe1f9be456565bbb26f6f555c78be8060bcea7"
integrity sha512-AzIXOBAdUnOIO91vhCPdtQH+W6pKi4rCrXsT6Fe/BN+KUoeMAsfOyBXRbA5lSQ1pb+gA2e9N4PGpOzFs6fI4hQ==
version "2.6.0"
resolved "https://registry.yarnpkg.com/@shopify/polaris-tokens/-/polaris-tokens-2.6.0.tgz#1654c83025d80ce803f06329aceaabfb96b5e684"
integrity sha512-l2AwgZhujgu/C1cchJginWODXWcjhrpqrh+lcI+SM3MSSca6l2zSXa3B5OqCcspk6DIQDeJEn5BvXJgT7AJNPQ==

"@shopify/polyfills@^0.0.10":
version "0.0.10"
Expand Down

0 comments on commit 7ddc216

Please sign in to comment.