Skip to content

Commit

Permalink
[yarn tophat] Fix app loading issues on Heroku (Shopify#2027)
Browse files Browse the repository at this point in the history
* Enforce NODE_ENV to be picked up in Heroku (set to 'development')

* Enable sourcemaps for easier debugging
  • Loading branch information
kaelig authored Aug 27, 2018
1 parent 7ac4aa7 commit 19e114c
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 1 deletion.
3 changes: 3 additions & 0 deletions app.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
"env": {
"YARN_PRODUCTION": {
"required": true
},
"NODE_ENV": {
"required": true
}
},
"formation": {
Expand Down
2 changes: 1 addition & 1 deletion tophat/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"noUnusedLocals": true,
"noEmitHelpers": true,
"importHelpers": true,
"sourceMap": false,
"sourceMap": true,
"lib": ["dom", "es2015", "es2016", "es2017", "dom.iterable", "scripthost"],
"resolveJsonModule": true,
"declaration": true,
Expand Down
2 changes: 2 additions & 0 deletions tophat/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ module.exports = {
'@shopify/polaris/styles/global.scss',
path.join(__dirname, 'index.tsx'),
],
devtool: 'source-map',
output: {
filename: '[name].js',
path: path.resolve(__dirname, 'assets'),
Expand Down Expand Up @@ -70,6 +71,7 @@ module.exports = {
{
loader: 'awesome-typescript-loader',
options: {
sourceMap: true,
silent: true,
useBabel: true,
useCache: true,
Expand Down

0 comments on commit 19e114c

Please sign in to comment.