Skip to content

Commit

Permalink
Update to latest sewing-kit
Browse files Browse the repository at this point in the history
Update a few dependencies that we want to keep in sync with sewing-kit

Use `sewing-kit optimize` to optimize svgs instead of maintaining our
own script which does the same thing.
  • Loading branch information
BPScott committed May 8, 2019
1 parent 43e1055 commit 0edecb7
Show file tree
Hide file tree
Showing 6 changed files with 1,342 additions and 1,174 deletions.
1 change: 0 additions & 1 deletion .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
"extends": [
"plugin:shopify/typescript",
"plugin:shopify/react",
"plugin:shopify/eslint-comments",
"plugin:shopify/jest",
"plugin:shopify/node",
"plugin:shopify/polaris",
Expand Down
3 changes: 2 additions & 1 deletion UNRELEASED.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f
- Update most `devDependencies` ([#1327](https://github.com/Shopify/polaris-react/pull/1327))
- Bump `@shopify/react-utilites` to remove a transitive dependency on `core-js` ([#1343](https://github.com/Shopify/polaris-react/pull/1343))
- Updated App Bridge to version 1.3.0 ([#1349](https://github.com/Shopify/polaris-react/pull/1349))
- Updated TypeScript to 3.2.4 ([#1388](https://github.com/Shopify/polaris-react/pull/1388))
- Updated typescript to 3.2.4 ([#1388](https://github.com/Shopify/polaris-react/pull/1388))
- Updated sewing-kit to 0.83.1 and babel-preset-shopify to ^18.1.0 ([#1344](https://github.com/Shopify/polaris-react/pull/1344))

### Code quality

Expand Down
2 changes: 1 addition & 1 deletion babel.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ module.exports = function(api) {
});

const runtimePreset = isWeb
? ['babel-preset-shopify/web', {modules: false}]
? ['babel-preset-shopify/web', {modules: false, useBuiltIns: 'entry'}]
: ['babel-preset-shopify/node', {modules: 'commonjs'}];

// babel-preset-shopify/react only uses HMR if hot is true and the env is
Expand Down
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"check:ci": "npm-run-all lint ts test:ci",
"clean": "rimraf build esnext styles types docs \"build-intermediate\" \"index.*\" \"./src/styles/polaris-tokens\" \"styles.{css,scss}\"",
"clean:build": "rimraf \"build/!(cache|coverage|storybook)\" esnext styles types docs \"build-intermediate\" \"index.*\" \"./src/styles/polaris-tokens\" \"styles.{css,scss}\"",
"optimize": "node ./scripts/optimize.js",
"optimize": "sewing-kit optimize",
"prebuild": "npm-run-all clean:build optimize copy-polaris-tokens",
"build": "node ./scripts/build.js",
"prebuild-consumer": "yarn run build",
Expand Down Expand Up @@ -91,11 +91,11 @@
"ios >= 9"
],
"devDependencies": {
"@babel/core": "^7.1.6",
"@babel/core": "^7.4.3",
"@percy/storybook": "^3.0.1",
"@shopify/jest-dom-mocks": "^2.1.1",
"@shopify/js-uploader": "github:shopify/js-uploader",
"@shopify/sewing-kit": "0.69.0",
"@shopify/sewing-kit": "0.83.1",
"@storybook/addon-a11y": "^5.0.6",
"@storybook/addon-actions": "^5.0.6",
"@storybook/addon-backgrounds": "^5.0.6",
Expand All @@ -112,7 +112,7 @@
"aws-sdk": "^2.58.0",
"babel-core": "7.0.0-bridge.0",
"babel-loader": "^8.0.5",
"babel-preset-shopify": "^17.0.1",
"babel-preset-shopify": "^18.1.1",
"chalk": "^2.4.2",
"change-case": "^3.1.0",
"codecov": "^3.3.0",
Expand Down
37 changes: 0 additions & 37 deletions scripts/optimize.js

This file was deleted.

Loading

0 comments on commit 0edecb7

Please sign in to comment.