Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to Join Commit Team #2168

Conversation

reeganviljoen
Copy link
Collaborator

What are you trying to accomplish?

After participating in 20 released features/bugs so far over almost a year and a half(wow that long already) and being of use in triaging issues, my contribution to this project has been a highlight of this time truly, and I would love nothing more than to stay on this journey of building the future of the Rails UI layer for the world to use. I feel being a part of this team will enable me to do this to an even better degree in the future as we head for V4. I feel this will help me be of use when people are struggling to get their pr's further across the line when everyone else is busy(we all do this when we can but that's sometimes a tough thing to do).
I would really appreciate this being taken into consideration

Thank you to the whole team that continues to make this possible everyday 🥇

reeganviljoen and others added 3 commits November 21, 2024 22:54
* add rails 8 appraisal

* add rails 8 ci

* fix lint

* updatre gemfile

* fix lint

* fix specs

* fix specx=cs again

* fix specs

* fix specs

* f*** these specs already

* fix lint

* fix benchmarks

* f*** these specs already

* fix lint

* fis spcs

* fix ci

* Update test/sandbox/test/rendering_test.rb

Co-authored-by: Cameron Dutro <[email protected]>

* fix ci

* fix lint

* fix lint

* try fix benchmark ci

* Apply suggestions from code review

* Update test/sandbox/test/rendering_test.rb

---------

Co-authored-by: Cameron Dutro <[email protected]>
Co-authored-by: Joel Hawksley <[email protected]>
@reeganviljoen reeganviljoen force-pushed the rv_add_reegab_to_commiters_team branch from 2c93810 to a37799e Compare November 21, 2024 20:55
@joelhawksley
Copy link
Member

Hey Reegan, thanks for opening this PR, and more importantly, all of your contributions over the past year and a half. You have certainly been a valuable member of the team, and we hope that continues! We don't typically make these decisions openly in issues, but we've heard your request and will discuss it among the rest of the committers.

In the interest of full transparency, we've been hesitant to add more committers to the project given the state of the project and the current level of time we're able to dedicate to ViewComponent. Like I mentioned before, we'll discuss the subject but will be closing the PR in the meantime.

@reeganviljoen
Copy link
Collaborator Author

@joelhawksley I appreciate the consideration and transparency, can't wait to hear either way from you 😄

@joelhawksley
Copy link
Member

Hi Reegan! Did you see my email? If not, email me at [email protected] so I have your contact info ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants