Expose .identifier
#2153
Merged
Expose .identifier
#2153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelhawksley
force-pushed
the
expose-source-location
branch
from
23f5f07 to
cc3f782
Compare
|
This might break some applications using view_component-contrib. Their README recommends creating an |
jcoyne
added a commit
to sul-dlss/sul-embed
that referenced
this pull request
Jan 6, 2025
It's now part of ViewComponent ViewComponent/view_component#2153
jcoyne
added a commit
to sul-dlss/exhibits
that referenced
this pull request
Jan 6, 2025
This is now defined in view_component ViewComponent/view_component#2153
jcoyne
added a commit
to sul-dlss/exhibits
that referenced
this pull request
Jan 6, 2025
This is now defined in view_component ViewComponent/view_component#2153
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
As a follow-up to #2106, I'm formally exposing
.source_locationas part of the public API, as it seems New Relic could make good use of this feature. (See their fallback in https://github.com/newrelic/newrelic-ruby-agent/blob/dev/CHANGELOG.md#v9150 💔 )What approach did you choose and why?
I made
.identifierpublic and used the term internally, assource_locationis a reserved word in Ruby.