Set request full path with request url #1893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nachiket87
force-pushed
the
fix-request-fullpath
branch
3 times, most recently
from
344d6e4 to
f9e2d4b
Compare
nachiket87
force-pushed
the
fix-request-fullpath
branch
from
f9e2d4b to
96a8b71
Compare
nachiket87
changed the title
nachiket87
force-pushed
the
fix-request-fullpath
branch
3 times, most recently
from
e78c014 to
7bffc84
Compare
nachiket87
force-pushed
the
fix-request-fullpath
branch
from
7bffc84 to
65b63c4
Compare
nachiket87
changed the title
camertron
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
Awesome, thank you @nachiket87 😄 I'm fine merging this, but I would heartily recommend submitting a patch upstream as well.
claudiob
pushed a commit
to claudiob/view_component
that referenced
this pull request
Dec 22, 2023
claudiob
pushed a commit
to claudiob/view_component
that referenced
this pull request
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Fixing #1867
What approach did you choose and why?
Issue may be a Rails issue here: https://github.com/rails/rails/blob/8e73e620b1072c831b81604449385dfbb60bdb63/actionpack/lib/action_dispatch/http/request.rb#L262
Where
@fullpathis cached from previous request. To get around this, I have manually set the values of@fullpathand@original_fullpathin the test helper.A similar issue was fixed here: 4241a14