Don't add ActionDispatch::Static middleware continued #1892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case that rails do not serve static files is not necessary to add ActionDispatch::Static middleware. Making possible to deploy ViewComponenets previews on a production environment where Nginx or Apache is managing the static files.
Co-authored-by: Joel Hawksley <[email protected]>
camertron
requested changes
Nov 1, 2023
Co-authored-by: Cameron Dutro <[email protected]>
Co-authored-by: Cameron Dutro <[email protected]>
Co-authored-by: Cameron Dutro <[email protected]>
Co-authored-by: Cameron Dutro <[email protected]>
Co-authored-by: Cameron Dutro <[email protected]>
|
@camertron can you please re-review this when you can 🙏 |
camertron
approved these changes
Nov 6, 2023
|
@camertron Its been rebased and is ready to merge 🙏 |
Spone
requested changes
Nov 7, 2023
Co-authored-by: Hans Lemuet <[email protected]>
camertron
approved these changes
Nov 7, 2023
claudiob
pushed a commit
to claudiob/view_component
that referenced
this pull request
Dec 22, 2023
…1892) * Don't add ActionDispatch::Static middleware In the case that rails do not serve static files is not necessary to add ActionDispatch::Static middleware. Making possible to deploy ViewComponenets previews on a production environment where Nginx or Apache is managing the static files. * Apply suggestions from code review Co-authored-by: Joel Hawksley <[email protected]> * Update index.md * add: prism cdn if no asset precompiler found * edit: change prism cdn version to 1.28 * Update app/helpers/preview_helper.rb Co-authored-by: Cameron Dutro <[email protected]> * Update app/helpers/preview_helper.rb Co-authored-by: Cameron Dutro <[email protected]> * Update app/helpers/preview_helper.rb Co-authored-by: Cameron Dutro <[email protected]> * Update app/helpers/preview_helper.rb Co-authored-by: Cameron Dutro <[email protected]> * Update lib/view_component/engine.rb Co-authored-by: Cameron Dutro <[email protected]> * edit: fix brocken tests * edit: refactor tests * edit: fix for rails > 6.1 * edit: fix lint issues * Update lib/view_component/engine.rb Co-authored-by: Hans Lemuet <[email protected]> --------- Co-authored-by: Daniel Gonzalez <[email protected]> Co-authored-by: Joel Hawksley <[email protected]> Co-authored-by: Cameron Dutro <[email protected]> Co-authored-by: Hans Lemuet <[email protected]>
claudiob
pushed a commit
to claudiob/view_component
that referenced
this pull request
Jan 3, 2024
…1892) * Don't add ActionDispatch::Static middleware In the case that rails do not serve static files is not necessary to add ActionDispatch::Static middleware. Making possible to deploy ViewComponenets previews on a production environment where Nginx or Apache is managing the static files. * Apply suggestions from code review Co-authored-by: Joel Hawksley <[email protected]> * Update index.md * add: prism cdn if no asset precompiler found * edit: change prism cdn version to 1.28 * Update app/helpers/preview_helper.rb Co-authored-by: Cameron Dutro <[email protected]> * Update app/helpers/preview_helper.rb Co-authored-by: Cameron Dutro <[email protected]> * Update app/helpers/preview_helper.rb Co-authored-by: Cameron Dutro <[email protected]> * Update app/helpers/preview_helper.rb Co-authored-by: Cameron Dutro <[email protected]> * Update lib/view_component/engine.rb Co-authored-by: Cameron Dutro <[email protected]> * edit: fix brocken tests * edit: refactor tests * edit: fix for rails > 6.1 * edit: fix lint issues * Update lib/view_component/engine.rb Co-authored-by: Hans Lemuet <[email protected]> --------- Co-authored-by: Daniel Gonzalez <[email protected]> Co-authored-by: Joel Hawksley <[email protected]> Co-authored-by: Cameron Dutro <[email protected]> Co-authored-by: Hans Lemuet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
I am attempting to finish #1091 by adding prism through a cdn when no asset pipeline is present
What approach did you choose and why?
When their is no asset pipeline I decided to serve prism through a cdn