Avoid allocating new string when output_postamble is blank

ViewComponent · Nov 27, 2023 · 38077f6 · 38077f6
1 parent bfee458
commit 38077f6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
@@ -10,6 +10,10 @@ nav_order: 5
 
 ## main
 
+* Avoid duplicating rendered string when `output_postamble` is blank
+
+    *Mitchell Henke*
+
 * Remove unsupported versions of Rails & Ruby from CI matrix.
 
     *Reegan Viljoen*

diff --git a/lib/view_component/base.rb b/lib/view_component/base.rb
@@ -104,7 +104,11 @@ def render_in(view_context, &block)
       before_render
 
       if render?
-        render_template_for(@__vc_variant).to_s + output_postamble
+        if output_postamble.blank?
+          render_template_for(@__vc_variant).to_s
+        else
+          render_template_for(@__vc_variant).to_s + output_postamble
+        end
       else
         ""
       end