This repository has been archived by the owner on Aug 9, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test refactoring.
Problem:
Conditions within the test method will alter the behavior of the test and its expected output, and would lead to situations where the test fails to detect defects in the production method since test statements were not executed as a condition was not met.
Solution:
Instead of using a conditional to control the test execution, we use the proper JUnit API with assumeFalse. In this case, using assumeFalse, the test method will not fail, but be ignored, since the subject under test could not be tested.
Result:
Before:
if (!cacheDir.mkdirs()) {
throw new IllegalStateException("Cannot create temporary directory");
}
if (!cacheDir.setWritable(false, false)) {
throw new IllegalStateException("Cannot modify permissions");
}
After:
Assume.assumeTrue("Cannot create temporary directory", !cacheDir.mkdirs());
Assume.assumeFalse("Cannot modify permissions", !cacheDir.setWritable(false, false));