More negative test cases #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure 'expect' conditions/assertions are actually evaluated.
Without 'depends', test ordering is not necessarily guaranteed, even if tests tend to run in top-to-bottom order. Let's ensure 'maybe-skipped' comes after one of the failing tests using 'depends' (any failing test would do).
|
Aside: I'm tempted to move some of the examples into a new directory under |
kanaka
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some missing test cases to support future refactoring/simplification of the control flow and exception handling.
I've also added a 'depends' to the 'maybe-skipped' example. While the total passed/failed counts have been reliable, my understanding is that test ordering is not actually guaranteed without 'depends'.