Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --verbose and --schema-file/DCTEST_SCHEMA options. #2

Merged
merged 2 commits into from
May 28, 2024

Conversation

kanaka
Copy link
Collaborator

@kanaka kanaka commented May 28, 2024

No description provided.

Add to the script file to find the schema file relative to the location
of the executable.
@kanaka kanaka force-pushed the verbosity-and-schema-location branch from e6bd918 to 1f200b8 Compare May 28, 2024 17:19
@kanaka kanaka requested a review from jonsmock May 28, 2024 17:19
src/dctest/core.cljs Outdated Show resolved Hide resolved
Copy link
Collaborator

@jonsmock jonsmock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. We'll use this right away as well.

If --verbose is specified, then show each command that is being run and
the stdout and stderr from each command as the chunks are received
(on the caller's stdout and stderr respectively).

The verbose command and stdout/stderr are indented so that the normal
test and step names/messages are more clearly indicated. Also, since
"print" uses console.log (implied newline), trim newlines from the end
of each chunk of output/error so that we don't get spurious newlines (we
still could if the chunk boundaries are not at newlines, but it should
be rare).
@kanaka kanaka force-pushed the verbosity-and-schema-location branch from 1f200b8 to 6b50e6c Compare May 28, 2024 17:59
@kanaka kanaka merged commit 76a2ab3 into main May 28, 2024
4 checks passed
@kanaka kanaka deleted the verbosity-and-schema-location branch June 3, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants