Support env and repeat #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the node version warning.
scripts/nbb can be symlinked from anywhere and will: - find nbb or return an error to the user - setup the appropriate classpath - run a cljs file of the same name in the target/current directory
Runs tests with nbb during development and in GHA workflows. Runs tests with shadow-cljs when building Docker images, failing the build when tests fail.
Simplifying the implementation before adding more features, and introducing expected user-impacting changes now to minimize future breakage for early adopters. Test ids support 'needs'-based control flow and other potential functionality, so make 'tests' a mapping. Remove setup/teardown steps for the suite and test levels, which complicate the code and will likely be replaced by other control flow features and/or reusable steps.
Defines a JSON Schema specification for test suite input. Additionally, normalize the suite after validation. Test ids, while not currently used, should be normalized from keywords to strings (as should any user-provided identifier).
Allow users to create env maps at the suite, test, or step levels. env values are coerced to strings by ajv. env keys are normalized as strings. This simplifies passing them to dockerode and will be useful when we add expressions that reference env variables. Upgrade shadow-cljs to get ClojureScript version with update-keys/update-vals.
Allows retrying exec/run commands until they succeed. API for 'repeat' inspired by docker compose's 'healthcheck' options. Supplying 'repeat' without setting 'retries' will retry indefinitely.
kanaka
approved these changes
May 24, 2024
| @@ -0,0 +1,103 @@ | |||
| ;; Copyright (c) 2024, Viasat, Inc | |||
There was a problem hiding this comment.
A good chunk of this I think originally came or was derived from cljs.utils. Since you're now pulling that dep in for repeat/retry functionality, seems like you could use other utils too instead of redefining them here.
Use functions from cljs-utils instead of redefining them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting some basics in place now that we are getting some very early initial users internally.
Also includes some minor cleanup and preparation for CLJS tests.