-
Notifications
You must be signed in to change notification settings - Fork 53
Conversation
Added workaround for SAM ambiguity on 2.12
sleep to prevent deadlock in 2.12
…alue that isn't the expected type
This depends on a release of Verizon/ermine-parser#3. |
@@ -0,0 +1,7 @@ | |||
package knobs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rossabaker File needs a copyright notice.
version.sbt
Outdated
@@ -1 +1 @@ | |||
version in ThisBuild := "3.12.0-SNAPSHOT" | |||
version in ThisBuild := "3.13.0-SNAPSHOT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the changes here, should we do a major revision? This seems like we introduced some changes we know are not compatible. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually here's a more compelling reason: we're dropping support for scalaz-stream 0.7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to major version 4
@@ -0,0 +1,64 @@ | |||
package verizon.build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File needs a copyright notice.
ValueError
(includes introduced a ValueError that represents an error caused by a config value that isn't the expected type #43)-scalaz-7.x
version qualifier. This will be Verizon's convention moving forward.Fixes #45