Skip to content
This repository has been archived by the owner on Mar 11, 2020. It is now read-only.

Release for 2.12 #51

Merged
merged 19 commits into from
Feb 24, 2017
Merged

Release for 2.12 #51

merged 19 commits into from
Feb 24, 2017

Conversation

rossabaker
Copy link
Contributor

@rossabaker rossabaker commented Feb 23, 2017

Fixes #45

@rossabaker
Copy link
Contributor Author

This depends on a release of Verizon/ermine-parser#3.

@rossabaker rossabaker mentioned this pull request Feb 23, 2017
@@ -0,0 +1,7 @@
package knobs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rossabaker File needs a copyright notice.

version.sbt Outdated
@@ -1 +1 @@
version in ThisBuild := "3.12.0-SNAPSHOT"
version in ThisBuild := "3.13.0-SNAPSHOT"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the changes here, should we do a major revision? This seems like we introduced some changes we know are not compatible. WDYT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually here's a more compelling reason: we're dropping support for scalaz-stream 0.7

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to major version 4

@@ -0,0 +1,64 @@
package verizon.build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File needs a copyright notice.

@timperrett timperrett merged commit c758d62 into Verizon:master Feb 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants