This repository has been archived by the owner on Mar 11, 2020. It is now read-only.
Upgrade to Scalaz-Stream 0.8a/Scalaz 7.2 #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgrade to `ermine-parser` 0.3 (recompiled against scalaz 7.2) - Fix deprecation warnings. Rename `run*` -> `unsafePerform*`
|
@ktonga this doesn't build, so we cant merge it. |
|
@timperrett I put a note in the PR comment, the problem also was in the ermine fork you use, so I had to upgrade it too. This PR depends on a new version of ermine which should be deployed for this build to succeed. |
|
@ktonga ok - sorry. well, as discussed, we need to put this on a branch, as we cannot migrate just yet. If i make a branch other than master, can you alter the PR to target that branch? This would also require changing travis to build things other than master etc etc... lots of details. |
|
@timperrett sure no problem, I can reopen the PR targeting the new branch. You think I can help with the travis work? |
|
Closing due to #29 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ermine-parser0.3 (recompiled against scalaz 7.2)run*->unsafePerform*NOTE: Verizon/ermine-parser#1 must be merged and deployed first