moreUserTags: attempt to rewrite

[henmalib]

Reason:

While discord hasn't pushed to stable i'm trying to rewrite patches, so they work both on canary and stable

Currently I've got tags working in messages:

• Messages
• Threads
• Member list
• User profile
• Ensure stability
• Maybe refactoring

[Vendicated]

by rewrite I meant make patches less dependant on one another. for example, implement this without adding new members to Discord's enums

[Vendicated]

right now, the plugin targets so many different modules and if even one single patch breaks, everything else stops working and either causes crashes or makes everyone have APP tag or stuff like that

more robust means that the plugin either works or fully breaks (silently), not constantly this in between

[henmalib]

by rewrite I meant make patches less dependant on one another. for example, implement this without adding new members to Discord's enums

Well, I'll look what i can do about it
Currently I'm saving tagObj to use it later without dependency, but without a patch for creating tags discord doesn't resolve it as a number ( maybe i just too eepy rn, will look later how to avoid it )

right now, the plugin targets so many different modules and if even one single patch breaks, everything else stops working and either causes crashes or makes everyone have APP tag or stuff like that

more robust means that the plugin either works or fully breaks (silently), not constantly this in between

That's how i see it:

• fewer patches
• patches are easier to read/modify
• patches shouldn't depend on one another
• patches shouldn't depend on things that might change easily (like current one for messages, I've already tried to make it better than before, but yeah, it needs improvement )

[henmalib]

Got it working without adding/changing discord's tags object, gonna eep now

[Vendicated]

nini

[henmalib]

While reading through the deleted file I've got a question:

Should i support data attributes for theming? If I'm not wrong you can just grab content in css for same results

Tags inside of profile were reliant on 2-3 patches, I'll try to reduce, but if I wouldn't find a way to do this: should i just drop support for it? Seeing tags from member list/message isn't that hard

[henmalib]

Okay, so OP tags are working out of the box, i have no idea why original one had a patch with a comment "show OP tags correctly"

Also I've added member list

I've left a comment how it currently patches discord code and I'm not sure if it's gonna be safe enough ( kinda feel weird because of the assignment inside parenthesis).
If someone can give a feedback about current state of patches it will be appreciated

[henmalib]

Tags in profile are also now here

It doesn't work with bots and requires 2 patches... I'm not happy about it

short explanation why:
Render DOM looks like:

server_profile(user,channelId):
	top_part(user)

Username, pronouns, tags are rendered inside top_part and for tags we need channelId, so the only way i know is prop it down from server_profile

It works and if patch with server_profile dies or doesn't exists at all - we will just get 0 tags in profiles ( bot tags will be present ).

Original plugin has 4 patches for profiles, including bot ones, so idk how to proceed with it

2 patches with "safe fail" seems reasonable, but still not perfect
adding 3rd patch just for tags for bots seems a lot
dropping profile support altogether - easier to maintain, lose some functionality ( are many people need tags there? )

[henmalib]

Using MessageDecoratior API i can get almost the same results without using any patches ( thanks theCodeToad )

But we are losing tags in replies like here

And bots are... ugh, should find a way to remove default one

ngl, i feel like a Davin doing all these comments

[henmalib]

lange rede kurzer sinn

It looks like i can't remove default tag without another patch, so what's the point of decorations if it still requires patching?

Also MessageDecorationProps.decorations seems to be undefined

[OIRNOIR]

Will there be an option to set tag colors as the guild member color (similar to #2161)? I personally think user tags are informative but very ugly when members' tags use the bot colors because it makes it harder to differentiate between priviliged members and bots at first glance.

[henmalib]

Will there be an option to set tag colors as the guild member color (similar to #2161)? I personally think user tags are informative but very ugly when members' tags use the bot colors because it makes it harder to differentiate between priviliged members and bots at first glance.

Your plugins add a bunch of new patches which caused this plugin to get deleted

I might try to recreate it using decorations, then they will be a lot more useful

[henmalib]

I would love to hear answers to the following questions by someone (Vee or Nuckyz):

• Should data attributes be supported like in an original plugin?
• Tags inside of a profile require 3 patches ( for both bots and users ), which are going to be dependent on one another. Should I support it? If one of the patches breaks, default tag will be displayed ( none for users, app for bots )
• If adding a plugin idea from @OIRNOIR, it's probably to use DecorationsAPI, but will require a patch to remove default tags. What seems more reasonable: changing tags directly or removing them?

[TheKodeToad]

And bots are... ugh, should find a way to remove default one

My solution was just not to try and merge the bot and custom tag. I always found separating them with • to be somewhat weird - and this works just fine IMO:

(also allows styling the tag separately 🎉)

Of course you can't add everything with decorators though, my plugin is admittedly unfinished and will eventually need a few patches

I thought it might be appreciated to do a direct port of my plugin since it also has icon support and you can add as many custom tags as you want

but looks like this plugin is in a better/more mergeable state since I last checked

[henmalib]

My solution was just not to try and merge the bot and custom tag. I always found separating them with • to be somewhat weird - and this works just fine IMO:

That might be a nice solution, but wouldn't it look weird with [APP] [WEBHOOK]?

Of course you can't add everything with decorators though
Well, the only thing i haven't seen an API for was for user profiles, messages/member list are quite easy

I'll probably change to decorations again tomorrow, try to implement a pr from OIRNIOR and will use splitting like you do

[lolsuffocate]

Well, the only thing i haven't seen an API for was for user profiles, messages/member list are quite easy

I believe Nuckyz just PR'd an API for this #3197

[henmalib]

Well, the only thing i haven't seen an API for was for user profiles, messages/member list are quite easy

I believe Nuckyz just PR'd an API for this #3197

Well, untill it gets merged there's no point of relying on it
But thanks for pointing this out. I'm pretty sure It will get merged soon, so yeah
Decorations might be the way to go

[TheKodeToad]

That might be a nice solution, but wouldn't it look weird with [APP] [WEBHOOK]?

True, I just didn't implement webhook tags. That could become a separate plugin again or just have its own handling... because surely just changing a message is unlikely to break that much

[Nuckyz]

I've changed the decorators API a bit, so now if you want to use them you no longer need to manually add margin or align vertically in messages. If you want those changes just merge dev into your branch

For the NicknameIconsAPI, I will work a bit more in improving PlatformIndicators and then I plan to merge that into dev as well, shouldnt take much

[henmalib]

Yop, decorations without trying to override original ones are good
The only thing that seems to be weird for me is that [ADMIN] comes before [APP], but it messages it goes in another direction

The only thing left is profiles, which currently requires 3 patches
( 1st is to make discord use our tags, 2nd to prop guild/channel to user profile, 3rd is to actually display it )

And it seems that #3197 has only userId, so... there is a choice
3 patches to have tags in 1 place or just drop user profile support. I don't see other solutions now

[TheKodeToad]

2nd to prop guild/channel to user profile

Just use SelectedChannelStore - it shouldn't be possible to open a profile for another channel I don't believe
Edit: just remembered the new modal sometimes shows guild profile and sometimes global profile. I suppose that could cause problems.

[henmalib]

Just use SelectedChannelStore - it shouldn't be possible to open a profile for another channel I don't believe

Fire, I didn't knew that this existed or totally forgot about it. Now i should just wait till new API drops and this plugin going to be gluten patch free

Edit: just remembered the new modal sometimes shows guild profile and sometimes global profile. I suppose that could cause problems.

Eehh, it's still a draft and we have time to see how it behaves, but SelectedStoreChannel should still have the same channel?

[henmalib]

Also profiles don't have any tags by default, so [APP] tags are missing there

I might just render 2 tags at the same time to stay consistent with every other field, but it is worth it?

[Nuckyz]

Also profiles don't have any tags by default, so [APP] tags are missing there

I might just render 2 tags at the same time to stay consistent with every other field, but it is worth it?

It does for me

[Nuckyz]

Also please merge dev into this branch! Both APIs you used had changes as I mentioned, and I'm pretty sure your tags are going to be off-center because of the classes you are adding, and the fact the APIs do the centering for you now

[Nuckyz]

I will also try to make it configurable so you can place your tags before Discord ones in messages

[henmalib]

It does for me

I forgot that i'm currently replacing the old one

Also please merge dev into this branch! Both APIs you used had changes as I mentioned, and I'm pretty sure your tags are going to be off-center because of the classes you are adding, and the fact the APIs do the centering for you now
Messages were off-center, I've removed both classes and rem-thingy, they are still off-centered, classes that i've used were from discord itself and that's how they used it

By default now:

Manually adding bottom .1rem to the component:

Member list seems fine by default anyway ( i haven't changed any classes )

[henmalib]

So discord usesRemSizies in messages, so should I

Manual padding by .1rem from the bottom is not perfect, but without it it looks really off-set

[Nuckyz]

They are different sizes, you should look how discord sets the size of the ones in messages and replicate that

[henmalib]

They are different sizes, you should look how discord sets the size of the ones in messages and replicate that

That's exactly how I'm doing it now
useRemSizes sets the height to be .975rem
Without it: 16px