Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added pets.yaml, added Pets texture folder, added Shopkeepers cat #642

Merged
merged 6 commits into from
Nov 4, 2024

Conversation

the-adom
Copy link
Contributor

added Haggis the cat

@6SpadesLuke
Copy link
Contributor

I thought his name was fishfood...

@the-adom
Copy link
Contributor Author

i looked around a little at other mobs but couldn’t find the code for different names on spawn o_O

#MARK: Haggis
- type: entity
name: Haggis
id: N14MobCatShopkeep
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth changing this to CatHaggis since it's the name people will search for

Copy link
Contributor

github-actions bot commented Nov 1, 2024

RSI Diff Bot; head commit 4af7554 merging into 308f909
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_Nuclear14/Mobs/Pets/cathaggis.rsi

State Old New Status
cathaggis Added
cathaggis_dead Added
cathaggis_rest Added
cathaggis_sit Added

Edit: diff updated after 4af7554

description: A little rough around the edges, but still cute as can be.
components:
- type: Sprite
- sprite: _Nuclear14\Mobs\Pets\cathaggis.rsi
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You added a - here thats not needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I went to go fix it myself before seeing you'd already pushed an update, you're too kind as always Peppy.

description: A little rough around the edges, but still cute as can be.
components:
- type: Sprite
sprite: _Nuclear14\Mobs\Pets\cathaggis.rsi
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ERRO] go.comp.sprite: Unable to load RSI '/Textures/_Nuclear14\Mobs\Pets\cathaggis.rsi'.

slashes the wrong way

@Peptide90 Peptide90 merged commit bb9a1e7 into Vault-Overseers:master Nov 4, 2024
9 checks passed
@the-adom the-adom deleted the nuclear-14-branch branch November 5, 2024 12:34
Peptide90 pushed a commit that referenced this pull request Nov 11, 2024
# Description

Cherry-picked from Delta-V, originally by @WarMechanic
(DeltaV-Station/Delta-v#1455).

Original Description:

> Every pair of gloves now has its own fingerprint, so items can be
traced back to gloves which can then be traced back to people.
> 
> ## Why / Balance
> 
> Evidence is very important to court cases running smoothly, so
detectives now have more evidence that can certify whether or not John
Syndicate's behaviour is valid. Traitors are now encouraged to either
clean evidence off syndicate gear regardless of glove status, or use a
disposable pair of gloves specifically for handling syndicate gear to be
disposed of later.
> 
> Aside from being required to obfuscate evidence you leave behind,
there is now a value proposition to searching glove prints of
departments. Wearing gloves that does not correspond your department can
punish an unknowing detective into searching the wrong people.
> 
> ## Technical details
> 
> `FiberComponent.cs` now stores a Fiberprint variable like
`FingerprintComponent.cs`. The code for assigning a fiberprint is the
same as the fingerprint. When evidence is placed on an object, the
fiberprint is concatenated to its localised fiber type.

<details><summary><h1>Original Media</h1></summary>
<p>

> hm ok we have these specific gloves on an akms
> <br>
> 
> <img
src="https://private-user-images.githubusercontent.com/69510347/345294367-55819ed3-1e89-401f-b7fb-0d8569bd7aa2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI1NjU2ODYsIm5iZiI6MTcyMjU2NTM4NiwicGF0aCI6Ii82OTUxMDM0Ny8zNDUyOTQzNjctNTU4MTllZDMtMWU4OS00MDFmLWI3ZmItMGQ4NTY5YmQ3YWEyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MDIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODAyVDAyMjMwNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTYxZWUxMjZjY2FiMTU1ODdlOGFiNDliN2ZjZjg4MmYxZmY3ZWY0MGMzN2UxZWM1MjA2MjBlYjY1ZDQ2YTJjMGYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.t5sASM_0is4bqd1YIizQ0lldAZ5RAStbNzXNuzHmdfU">
> 
> hm well we found the gloves and they have fingerprints
> <br>
> 
> <img
src="https://private-user-images.githubusercontent.com/69510347/345294443-a9b21171-bee5-4c5f-8ec6-cf5576572d45.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI1NjU2ODYsIm5iZiI6MTcyMjU2NTM4NiwicGF0aCI6Ii82OTUxMDM0Ny8zNDUyOTQ0NDMtYTliMjExNzEtYmVlNS00YzVmLThlYzYtY2Y1NTc2NTcyZDQ1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MDIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODAyVDAyMjMwNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM3ZTY3NjRhZmEzMjRhYTkwNjUyOWI3MzgzOGM0ZWRjY2Q3MTg0YzViN2NjMDQyZTgzMDBiMmZlZDAyYWJjYjUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.uSn27Drf1K8rcfQtYRo_fGKudbO03fp40GNHUSd4Uw0">
> 
> gotem
> <br>
> 
> <img
src="https://private-user-images.githubusercontent.com/69510347/345294064-d6254f48-2d81-4702-ac03-c1c796712ef4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI1NjU2ODYsIm5iZiI6MTcyMjU2NTM4NiwicGF0aCI6Ii82OTUxMDM0Ny8zNDUyOTQwNjQtZDYyNTRmNDgtMmQ4MS00NzAyLWFjMDMtYzFjNzk2NzEyZWY0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MDIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODAyVDAyMjMwNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTgzNWYzODBmOWVhYzQzMjMxNDdlMzk5Zjk2ODY4N2I1ZWNmYmNkNGI2NGFlMjZiMDM1NGVjNDJlOGFjNjViN2YmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.TjsSLQpLoGsXOHS-wl_LSASdLxgeVTKxCGugkX7-v90">

</details>
</p>

# Changelog

:cl: WarMechanic
- add: Gloves now have unique fingerprints. Items can be traced back to
gloves, which can then be traced back to people.

---------

Signed-off-by: Angelo Fallaria <ba.fallaria@gmail.com>
Co-authored-by: WarMechanic <69510347+WarMechanic@users.noreply.github.com>
Co-authored-by: deltanedas <39013340+deltanedas@users.noreply.github.com>
Co-authored-by: Danger Revolution! <142105406+DangerRevolution@users.noreply.github.com>
Co-authored-by: VMSolidus <evilexecutive@gmail.com>
Peptide90 pushed a commit that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants