-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor JobBlock code #634
Conversation
Hey, are you in the discord currently? Not sure if this is a feature of EE already but I will do an upstream merge of EE before merging this if not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is completely unecessary, we already have CharacterSpeciesRequirement, as a unified requirement that works on Jobs, Traits, Antags, and Loadouts.
It bothered my eyes quite a lot I will answer the first question, I do not belong to your circles, because besides that, I already belong to a large number of communities, and this could prevent me That's all |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Thank you for your contribution. To save us having to maintain two systems I will close this PR, since the functionality already exists. Maybe we have duplicate code already that can be removed. If you are interested in contributing C# though we do have a number of things to work on :) |
# Description Survival boxes take up a shitload of space, and very few people actually want them. Most people take the Epipen and Spacepen out, and throw the box away immediately on roundstart. Having survival boxes automatically in the backpack causes issues when Loadouts contain "large items", causing most or all of a person's loadout to be dumped on the floor at roundstart. While that isn't completely unavoidable, moving survival boxes to loadouts will go a long way towards ameliorating said issue. I intentionally omitted removing survival boxes from antagonist bags because we currently don't have antag character slots and loadouts. In the future when we have that update, we can remove survival boxes from the nukie bags too. # Changelog :cl: - add: Survival Boxes have been added to loadouts.
Description
As they say, why reinvent the wheel?
And even more so if it doesn't work
In short, what was done:
Media
Video for authenticity
https://github.com/user-attachments/assets/efe11869-639e-448f-83d3-8c9df066cfe1