Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor JobBlock code #634

Closed
wants to merge 1 commit into from

Conversation

Zekins3366
Copy link

Description

As they say, why reinvent the wheel?
And even more so if it doesn't work

In short, what was done:

  • Remove excess Shitcode
  • Add my Shitcode, but the worker

Media

Video for authenticity
https://github.com/user-attachments/assets/efe11869-639e-448f-83d3-8c9df066cfe1

@Peptide90
Copy link
Collaborator

Hey, are you in the discord currently? Not sure if this is a feature of EE already but I will do an upstream merge of EE before merging this if not.

Copy link
Contributor

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is completely unecessary, we already have CharacterSpeciesRequirement, as a unified requirement that works on Jobs, Traits, Antags, and Loadouts.

@Zekins3366
Copy link
Author

It bothered my eyes quite a lot
In general, it does not matter whether this PR is merged, in any case it was done by me on pure enthusiasm and the fact that it did not work for a very long time

I will answer the first question, I do not belong to your circles, because besides that, I already belong to a large number of communities, and this could prevent me

That's all

Copy link
Contributor

github-actions bot commented Nov 1, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Peptide90
Copy link
Collaborator

It bothered my eyes quite a lot In general, it does not matter whether this PR is merged, in any case it was done by me on pure enthusiasm and the fact that it did not work for a very long time

I will answer the first question, I do not belong to your circles, because besides that, I already belong to a large number of communities, and this could prevent me

That's all

Thank you for your contribution. To save us having to maintain two systems I will close this PR, since the functionality already exists. Maybe we have duplicate code already that can be removed. If you are interested in contributing C# though we do have a number of things to work on :)

@Peptide90 Peptide90 closed this Nov 1, 2024
Peptide90 pushed a commit that referenced this pull request Nov 11, 2024
# Description

Survival boxes take up a shitload of space, and very few people actually
want them. Most people take the Epipen and Spacepen out, and throw the
box away immediately on roundstart. Having survival boxes automatically
in the backpack causes issues when Loadouts contain "large items",
causing most or all of a person's loadout to be dumped on the floor at
roundstart. While that isn't completely unavoidable, moving survival
boxes to loadouts will go a long way towards ameliorating said issue.

I intentionally omitted removing survival boxes from antagonist bags
because we currently don't have antag character slots and loadouts. In
the future when we have that update, we can remove survival boxes from
the nukie bags too.

# Changelog

:cl:
- add: Survival Boxes have been added to loadouts.
Peptide90 pushed a commit that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants