Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NCR Update Parts 1 and 2 #626

Merged
merged 12 commits into from
Oct 27, 2024
Merged

Conversation

PursuitInAshes
Copy link
Contributor

@PursuitInAshes PursuitInAshes commented Oct 23, 2024

Description

NCO Slots on Sunnyvale now 2 minimum, 3 max.

MP and QM removed.
MP Kit Removed.

NCO job, items, references, renamed to SGT.
Officer Job, Items, references, renamed to LT.

Officer, NCO, and Doctor files have been renamed, see commit number 5

Removed Gunner kit from base trooper accessibility.
Created engineer kit (Base pointman kit but a toolbelt instead of a bandolier.)

Created WS and Engineer Jobs, both requiring 5h of playtime. Two slots for both jobs on Sunnyvale.

NCO and Officer access renammed correctly.
MP access nuked -> All MP access doors are now NCO access

Media

image

Map Changes Required

Junction will need mapped batons
Junction will need the new latejoin spawners
Junction will probably need more handcuffs/zipties mapped.
Latejoin spawners for WS and Engineer

Possible Issues

LT has rank pins that aren't LT (Captain and Major, maybe some more), if someone decides to be annoying it may be an issue.
Medic, LT, SGT might have kits still referencing their old names, but I don't think so, just need someone else to take a more proper look.

@PursuitInAshes PursuitInAshes marked this pull request as ready for review October 26, 2024 16:06
@PursuitInAshes PursuitInAshes changed the title [Draft] NCR Update NCR Update Part 1 Oct 26, 2024
@PursuitInAshes
Copy link
Contributor Author

I can't test the last commit because something is weird locally, but this should be fully functional and ready to merge.

@PursuitInAshes PursuitInAshes changed the title NCR Update Part 1 NCR Update Parts 1 and 2 Oct 27, 2024
@PursuitInAshes
Copy link
Contributor Author

PursuitInAshes commented Oct 27, 2024

I'm awaiting a response from ODJ on if I should make map changes or if they will put up a PR for them seperately.

The last commit (4274224) will result in sunnyvale being unable to load. Do not merge this PR until there is another PR from them changing the map file to fix it, or a commit of me fixing it. Aside from that this PR is entirely ready for review.

Edit: Migrations done, but would still be best to wait to merge and/or publish this until roundstart spawners exist for the major NCR roles again.

@Peptide90 Peptide90 merged commit 2296fe8 into Vault-Overseers:master Oct 27, 2024
8 checks passed
@PursuitInAshes PursuitInAshes deleted the NCRUpdate branch October 27, 2024 19:53
Peptide90 pushed a commit that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants