Release 2024.4.2 #362
Merged
Release 2024.4.2 #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ben Capodanno <[email protected]>
Co-authored-by: Ben Capodanno <[email protected]>
Moves script environment setup to the scripts directory. Uses Click to more easily manage script CLI options and invocation. Adds `with_database_session` to reduce code duplication on scripts that need db access.
A previous change had caused score set variant URNs to not update with the new score set non-tmp URN upon publication. This change fixes this regression and score set variant URNs will now be refreshed going forward.
**Notes** - I’ve retained the general target gene search, although we don’t currently have a use case for it. - I’ve added simple test cases for user-specific target gene search. We could probably add more target-gene-related cases, but these cover the changes made here.
List experiments in urn order.
Changes include: - A new `active` property within the database that indicates whether a license is active - The associated DB migration - A new `active` property on License view models to persist this property in API responses - Tests for the license router - Tests for (1) creating score sets with an invalid license (2) modifying a score set to have an invalid license, and (3) modifying a score set which has an in-active license is possible
…d-score-sets-still-have-tmp-accessions Refresh Variant URNs Upon Score Set Publication
…ront end won't show Add Score Set button in meta-analysis experiment page.
Fix a typo in comment.
…-target-category-constant Target Category Constant
…tInMetaAnalysisExp Not allowing adding score set to meta-analysis experiment.
…type-field Record Type Field
…-dataset-metadata Expand Editable Score Set Metadata
…-autocompletion User-specific target gene search
…te-permitted-licenses Update Permitted Licenses
…-mapping-script Variant Mapping Script (and script environment improvements)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: After migrating the database, you should run both the
refresh_published_tmp_urnsandmigrate_non_api_like_constantsscripts. You should also add the new data license and deprecate existing data licenses which are now outdated.Features/Enhancements
Bug Fixes
Housekeeping