Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] OD-1192: Add pdf return labels creation logic to return pickings. #5

Closed
wants to merge 5 commits into from
Closed

[ADD] OD-1192: Add pdf return labels creation logic to return pickings. #5

wants to merge 5 commits into from

Conversation

benrazanskas
Copy link

No description provided.

@benrazanskas
Copy link
Author

benrazanskas commented Jun 3, 2022 •
edited
Loading

So the thing is, i'm looking for solution to deal with vanmoof_shipping dependencies while was running OCA tests, since vanmoof_shipping has dependencies and raises lot of checks, maybe you guys have an idea how to overcome on this part. Short story: vanmoof_shipping is asking for box to be added before it lets to do smth about labels, so I had to include this here https://github.com/VanMoof/delivery-carrier/pull/5/files#diff-353f63d411d851c3fea1b07cf49d6ece34db580952e5659d16370bd41a32e687R122-R125
Maybe it's good thing to move unittests in our side modules?

@MPishpecki
Copy link

@benrazanskas we cannot deploy this with a tag. Can you please add it to the buildout the old way and inform us. Either @antonioburic or I deploy it manually or it goes with the next ticket that will be triggered for deployment.

@dkubiak789
Copy link

dkubiak789 commented Jun 20, 2022 •
edited
Loading

I added a PRs #505 to OCA/delivery-carrier and #1192 to buildout in odoo-addons.

@MPishpecki
Copy link

@dkubiak789 @benrazanskas is still fixing failing tests. Maybe too early for the OCA PR? If you are keeping it please make sure you update the OCA PR for the changes.

@benrazanskas benrazanskas mentioned this pull request Jun 22, 2022
Closed
@benrazanskas benrazanskas force-pushed the OD-1192-enable-paazl-return-labels branch from 6899a16 to 013ee7d Compare June 22, 2022 20:25
@benrazanskas benrazanskas force-pushed the OD-1192-enable-paazl-return-labels branch from 0a3140a to 64d809c Compare June 23, 2022 00:32
@antonioburic
Copy link

The last commit addresses the feedback from testing - inverted sender/receiver address for return labels.

@antonioburic antonioburic force-pushed the OD-1192-enable-paazl-return-labels branch from c5ed936 to eed7016 Compare July 19, 2022 06:21
@antonioburic antonioburic force-pushed the OD-1192-enable-paazl-return-labels branch from eed7016 to 494cd72 Compare July 20, 2022 05:36
@pankk
Copy link

pankk commented Mar 9, 2023

Stale upstream, but were are using the code. Due to a conflict this PR was merged into: #8

@pankk pankk closed this Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

@antonioburic antonioburic antonioburic approved these changes

@MPishpecki MPishpecki MPishpecki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@benrazanskas @MPishpecki @dkubiak789 @antonioburic @pankk @StefanRijnhart