Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -G "Unix Makefiles" for linux cmake commnad #1618

Closed
wants to merge 1 commit into from

Conversation

guysoft
Copy link

@guysoft guysoft commented Dec 14, 2021

Hey, that line has a typo. it should be -G "Unix Makefiles".

Without this line you get:

$ cmake .. -G Makefile  -DCMAKE_BUILD_TYPE=Release
CMake Error: Could not create named generator Makefile

Generators
* Unix Makefiles               = Generates standard UNIX makefiles.
  Green Hills MULTI            = Generates Green Hills MULTI files
                                 (experimental, work-in-progress).
...

Also

  1. it might be a good idea to point that the output is generated at ./samples/bin/linux64/helloworldoverlay I had to search for that too.
  2. The -DCMAKE_PREFIX_PATH= is not required in most distr
  3. Proff this compiles like this:
    Screenshot_20211214_184620

Hey, that line has a typo. it should be ``-G "Unix Makefiles"``.

Without this line you get:
```
$ cmake .. -G Makefile  -DCMAKE_BUILD_TYPE=Release
CMake Error: Could not create named generator Makefile

Generators
* Unix Makefiles               = Generates standard UNIX makefiles.
  Green Hills MULTI            = Generates Green Hills MULTI files
                                 (experimental, work-in-progress).
...
```

Also - do you know where the binaries are actually built to? I can find it
@okawo80085
Copy link

There is a bigger problem with that cmake command, it's making you think you have to use a specific generator to build, that's just plain wrong! Remove the generator argument entirely, there is no generator specific arguments passed so its fine to do that, cmake will choose the default generator installed on the system. It's less confusing that way.

@tort-oise
Copy link

Listen to the guy above. I'm pretty sure his fork fixes it.

@okawo80085
Copy link

I did, i'm saying it can be better. Literally removing the -G "Unix Makefiles" argument entirely is a better fix.

@guysoft
Copy link
Author

guysoft commented Dec 14, 2021

I was thinking that too, but thought someone wanted to make it more explicit for some reason, can close and open a new one for that.

guysoft added a commit to guysoft/openvr that referenced this pull request Dec 14, 2021
As suggested in  ValveSoftware#1618 , removing flags that are not required
@guysoft
Copy link
Author

guysoft commented Dec 14, 2021

Closing, see #1619

@guysoft guysoft closed this Dec 14, 2021
@okawo80085
Copy link

That works

@guysoft
Copy link
Author

guysoft commented Dec 14, 2021

@okawo80085 Feel free to comment there :)

@okawo80085
Copy link

Will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants