fix turtle canEnter logic

[zyxkad]

No description provided.

[zyxkad]

I do not know if there are better way to do this, because if the turtle is on a ship, blockPosition seems will return the turtle position in actual world, but it should return a shipyard position I'm not sure?

[Rubydesic]

Are these first two maps necessary? Aren't these two code snippets identical?

Streams.stream(ValkyrienSkies.positionToNearbyShipsAndWorld(world, position.getX() + 0.5, position.getY() + 0.5, position.getZ() + 0.5, 0.1))
    .map(pos -> ValkyrienSkies.getShipManagingBlock(world, pos))
    .map(s -> ValkyrienSkies.positionToShip(s, new Vector3d(position.getX() + 0.5, position.getY() + 0.5, position.getZ() + 0.5)))

Streams.stream(ValkyrienSkies.positionToNearbyShipsAndWorld(world, position.getX() + 0.5, position.getY() + 0.5, position.getZ() + 0.5, 0.1))

[zyxkad]

I don't know actually? if you sure they are same then I'll remove extra maps

[zyxkad]

I have no idea that what position is positionToNearbyShipsAndWorld returning.

[Rubydesic]

Can you test the code in

1. the game and check that it works as you expected
2. the debugger and set a breakpoint and check that the positions are as you expected

[zyxkad]

Can you test the code in

1. the game and check that it works as you expected
2. the debugger and set a breakpoint and check that the positions are as you expected

uhh i do not know how to test this. I can build this mod but it's unable load in game

[zyxkad]

I'll try again tomorrow anyway.

[zyxkad]

@Rubydesic

crash-2025-01-01_22.21.53-fml.txt
latest.log

[zyxkad]

Yeah I need Eureka to create ship, I don't know if I can make a ship by vs2 itself, but if you can provide any information it will be helpful.

[Rubydesic]

Please do not modify the build files in your PR. You can create a ship using the ship creator item in the creative menu.

[zyxkad]

Please do not modify the build files in your PR. You can create a ship using the ship creator item in the creative menu.

Uh but without strict kotlin version I cannot build the mod?

$ ./gradlew forge:build                                     
                                                                                                                                 
> Configure project :                                                                                                            
Architect Plugin: 3.4.146
Architectury Loom: 1.3.355
This version of Architectury Loom is in beta! Please report any issues you encounter: https://github.com/architectury/architectury-loom/issues
                                                                                                                                 
> Task :common:compileKotlin FAILED                                                                                              
                                                                                                                                 
FAILURE: Build failed with an exception.                                                                                         

* What went wrong:
Execution failed for task ':common:compileKotlin'.
> Inconsistent JVM-target compatibility detected for tasks 'compileJava' (17) and 'compileKotlin' (18).
  
  Consider using JVM Toolchain: https://kotl.in/gradle/jvm/toolchain
  Learn more about JVM-target validation: https://kotl.in/gradle/jvm/target-validation 

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.3/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD FAILED in 3s
1 actionable task: 1 executed

[zyxkad]

So without eureka there still problem when I create/load a world:

crash-2025-01-02_06.51.59-server.txt
latest.log

[zyxkad]

@Rubydesic

[zyxkad]

@Rubydesic Any updates?

[blockninja124]

The crash report I seem to remember is krunch not having enough (un-allocated?) RAM. I think somewhere theres a file that controls how much RAM is allocated while testing, maybe its more than your computers RAM?

(Or I'm completely wrong and the crash is something different)