Improved Dragging & Entity Interactions on Ships [Pathfinding, POIs, Raids, etc.] #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThePlasticPotato
changed the title
|
Can you fix the froge server failing? I think you're using some client side classes in a froge mixin |
I didn't notice that, I honestly thought those tests were just broken- I can fix it |
Rubydesic
requested changes
Dec 27, 2024
common/src/main/java/org/valkyrienskies/mod/mixin/client/renderer/MixinEntityRenderer.java
Show resolved
Hide resolved
common/src/main/java/org/valkyrienskies/mod/mixin/entity/MixinEntity.java
Show resolved
Hide resolved
common/src/main/java/org/valkyrienskies/mod/mixin/entity/MixinEntity.java
Show resolved
Hide resolved
common/src/main/java/org/valkyrienskies/mod/mixin/entity/MixinEntity.java
Show resolved
Hide resolved
...on/src/main/java/org/valkyrienskies/mod/mixin/feature/entity_collision/MixinLocalPlayer.java
Outdated
Show resolved
Hide resolved
...n/src/main/java/org/valkyrienskies/mod/mixin/feature/entity_collision/MixinServerEntity.java
Outdated
Show resolved
Hide resolved
...rg/valkyrienskies/mod/mixin/mod_compat/reachentityattributes/MixinReachEntityAttributes.java
Show resolved
Hide resolved
...c/main/java/org/valkyrienskies/mod/forge/mixin/feature/forge_interact/MixinIForgePlayer.java
Show resolved
Hide resolved
common/src/main/java/org/valkyrienskies/mod/mixinducks/world/entity/PlayerDuck.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the long-standing bug with extreme entity dragging delay, by allowing the client to guesstimate the mob's position.
Mobs are now dragged perfectly, even at ludicrous speed
Mob pathfinding on ships has been mildly tweaked
Mob rotation on ships has been fixed
Mob POI finding on ships has been enabled
Player targeting of blocks now works on ships while at high speeds or rotations.
Players can now hold open GUIs while on ships at high speeds or rotations.