Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having Nostalgic Tweaks installed breaks all sounds on ships. #987

Open
1 task done
hl2jeep opened this issue Oct 19, 2024 · 2 comments
Open
1 task done

Having Nostalgic Tweaks installed breaks all sounds on ships. #987

hl2jeep opened this issue Oct 19, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@hl2jeep
Copy link

hl2jeep commented Oct 19, 2024

This issue occurs when only Valkyrien Skies and addons are installed and no other mods

  • I have tested this issue and it occurs when no other mods are installed

Minecraft Version

1.20.x

Mod Loader

Forge

Issue description

With the Nostalgic Tweaks mod installed, regardless of whether it's enabled or any of the sound setting are toggled, there will be no sounds on ships what so ever.

Issue reproduction

  1. Install Forge + Valkyrian skies + nostalgic tweaks.
  2. run the game and build a ship
  3. notice that there will be no sound of block placing and breaking, aswell as footsteps.

Logs

N/A, no difference in logs between having nostalgic tweaks installed and not.
EDIT: Yes I did double check this, i wasn't able to find any differences between the logs of having it enabled and not, i made a fresh instance to test it out.

@hl2jeep hl2jeep added the bug Something isn't working label Oct 19, 2024
@hl2jeep
Copy link
Author

hl2jeep commented Oct 23, 2024

I think my previous log was damaged, here's the actual log file, srry Log

@xiewuzhiying
Copy link
Contributor

https://github.com/Adrenix/Nostalgic-Tweaks/blob/1.20.1/common/src/main/java/mod/adrenix/nostalgic/mixin/tweak/sound/position_sound/ClientLevelMixin.java

I suspect it's causing this issue, but I haven't gotten into the game to test it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants