Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cherry pick v2.0.0-rc.5's 2db63f4 #11

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Dec 8, 2024

内容

関連 Issue

Refs: VOICEVOX/voicevox_core#687, pykeio@2db63f4

スクリーンショット・動画など

Without this:

image

その他

@qryxip qryxip requested a review from Hiroshiba December 8, 2024 12:12
@qryxip qryxip changed the title fix: cherry pick v2.0.0-rc.5's 2db63f4 fix: cherry pick v2.0.0-rc.5's 2db63f419531b0f418d5f9934d7037f9e46c1b5c Dec 8, 2024
@qryxip qryxip changed the title fix: cherry pick v2.0.0-rc.5's 2db63f419531b0f418d5f9934d7037f9e46c1b5c fix: cherry pick v2.0.0-rc.5's ort@2db63f4 Dec 8, 2024
@qryxip qryxip changed the title fix: cherry pick v2.0.0-rc.5's ort@2db63f4 fix: cherry pick v2.0.0-rc.5's pykeio/ort@2db63f4 Dec 8, 2024
@qryxip qryxip changed the title fix: cherry pick v2.0.0-rc.5's pykeio/ort@2db63f4 fix: cherry pick v2.0.0-rc.5's pykeio@2db63f4 Dec 8, 2024
@qryxip qryxip changed the title fix: cherry pick v2.0.0-rc.5's pykeio@2db63f4 fix: cherry pick v2.0.0-rc.5's 2db63f4 Dec 8, 2024
@Hiroshiba
Copy link
Member

テストが落ちてそうでした!

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

変更自体はLGTM!

@qryxip
Copy link
Member Author

qryxip commented Dec 8, 2024

どうしようもなさそうなので放置でいいかなと思ってます。
(ちゃんとするのなら、その手間でv2.0.0-rc.5からv2.0.0-rc.9のマージをした方がよさそう)

@Hiroshiba
Copy link
Member

Hiroshiba commented Dec 8, 2024

なるほど。判断お任せします!

@qryxip qryxip merged commit 09a9fe1 into VOICEVOX:main Dec 8, 2024
5 of 7 checks passed
@qryxip qryxip deleted the fix-cherry-pick-2db63f4 branch December 8, 2024 12:34
qryxip added a commit to VOICEVOX/voicevox_core that referenced this pull request Dec 9, 2024
非同期APIにおける推論に`ort::Session::run_async`を使うようにする。これに
より、推論がキャンセル可能になる。

#888 の影響を受け推論が失敗するので、CIを通すため、Python APIのテストと
exampleについては(すべてのプラットフォームで)
`cpu_num_threads=max(multiprocessing.cpu_cout(), 2)`とする。

Resolves: #687
Refs: VOICEVOX/ort#11
BREAKING-CHANGE: 非同期APIにおいて、INTRA Thread Countが`1`だと推論がすべてエラーになる。
See-also: https://docs.rs/ort/2.0.0-rc.4/ort/struct.Session.html#method.run_async
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants