Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

テストを破壊してみる #8

Closed
wants to merge 1 commit into from
Closed

Conversation

sevenc-nanashi
Copy link
Member

内容

異常系テストです。

関連 Issue

(なし)

スクリーンショット・動画など

(なし)

その他

(なし)

@Hiroshiba
Copy link
Member

merge when readyを押させていただきます!!!

@Hiroshiba Hiroshiba enabled auto-merge January 1, 2025 11:23
@sevenc-nanashi
Copy link
Member Author

sevenc-nanashi commented Jan 1, 2025

落ちてそう、よさげ!

GATEKEEPER_TOKENにDisable auto-mergeできる程度の権限を持たせて自動でauto-mergeからも外すとかもやりたいけど、まぁとりあえずは良さそう?

@Hiroshiba
Copy link
Member

良さそうですね!!

enable_auto_mergeのタイミングじゃなく、merge-queueに入ったあとでもちゃんと落ちるか確かめても良いかもだけど、まあ大丈夫だろうということで!

あ、auto-mergeは外れないんですね!
まあでもauto-merge ONにしたあとCIが落ちて、それをコミッターが直したあとに自動的にマージしてくれそうだし、そのままでも良いかも・・・?

(全然関係ないけど、auto-mergeボタン押したあと悪意あるコミッターがウイルスをcommitしても気づきづらいかもしれない・・・)

@sevenc-nanashi
Copy link
Member Author

(全然関係ないけど、auto-mergeボタン押したあと悪意あるコミッターがウイルスをcommitしても気づきづらいかもしれない・・・)

After you enable auto-merge for a pull request, if someone who does not have write permissions to the repository pushes new changes to the head branch or switches the base branch of the pull request, auto-merge will be disabled.
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/automatically-merging-a-pull-request

公式ドキュメントによると、悪意ある外部コントリビューターが何かpushした時点で勝手にauto-mergeが切れるみたいです。

auto-merge was automatically disabled January 1, 2025 11:31

Pull request was closed

@sevenc-nanashi sevenc-nanashi deleted the change/destroy-ci branch January 1, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants