forked from takuyaa/kuromoji.js
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ブラウザ・Nodeを選択可能に #2
Merged
The head ref may contain hidden characters: "\u3059\u3079\u3066\u3092\u66F8\u304D\u63DB\u3048\u3046r"
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 33 out of 48 changed files in this pull request and generated no suggestions.
Files not reviewed (15)
- .codeclimate.yml: Language not supported
- .jshintrc: Language not supported
- .node-version: Language not supported
- .travis.yml: Language not supported
- bower.json: Language not supported
- demo/bower.json: Language not supported
- demo/tokenize.html: Language not supported
- jsdoc.json: Language not supported
- package.json: Language not supported
- CHANGELOG.md: Evaluated as low risk
- demo/js/tokenize.js: Evaluated as low risk
- example/load-node.js: Evaluated as low risk
- gulpfile.js: Evaluated as low risk
- src/dict/CharacterClass.js: Evaluated as low risk
- src/dict/CharacterDefinition.js: Evaluated as low risk
Comments skipped due to low confidence (2)
src/TokenizerBuilder.js:33
- The error message could be clearer. Suggest changing to:
Invalid value for nodeOrBrowser: ${node_or_browser}. Expected 'node' or 'browser'.
throw new Error(`nodeOrBrowser must be 'node' or 'browser': ${node_or_browser}`);
src/TokenizerBuilder.js:31
- Ensure that there is a test case covering the scenario where an invalid value is provided for nodeOrBrowser.
if (node_or_browser != "node" && node_or_browser != "browser") {
たぶん大丈夫なのでマージします! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
ブラウザ・Node用のクラスが自動選択されるようになっていましたが、引数で選択可能にしました。
これでNodeからもブラウザからも使いやすいと思います。
関連 Issue
その他
変更点は主に以下のとおりです。