Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ブラウザ・Nodeを選択可能に #2

Merged
merged 13 commits into from
Dec 15, 2024

Conversation

Hiroshiba
Copy link
Member

@Hiroshiba Hiroshiba commented Dec 7, 2024

内容

ブラウザ・Node用のクラスが自動選択されるようになっていましたが、引数で選択可能にしました。
これでNodeからもブラウザからも使いやすいと思います。

関連 Issue

その他

変更点は主に以下のとおりです。

  • ブラウザ・Node用のクラスをどちらもエクスポート
  • gulp等を削除し、node:testに移行
  • フォーマッターをprettierに
  • distを失くす
  • ESMに
  • 型ファイルも追加

@Hiroshiba Hiroshiba requested a review from Copilot December 7, 2024 17:28

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 33 out of 48 changed files in this pull request and generated no suggestions.

Files not reviewed (15)
  • .codeclimate.yml: Language not supported
  • .jshintrc: Language not supported
  • .node-version: Language not supported
  • .travis.yml: Language not supported
  • bower.json: Language not supported
  • demo/bower.json: Language not supported
  • demo/tokenize.html: Language not supported
  • jsdoc.json: Language not supported
  • package.json: Language not supported
  • CHANGELOG.md: Evaluated as low risk
  • demo/js/tokenize.js: Evaluated as low risk
  • example/load-node.js: Evaluated as low risk
  • gulpfile.js: Evaluated as low risk
  • src/dict/CharacterClass.js: Evaluated as low risk
  • src/dict/CharacterDefinition.js: Evaluated as low risk
Comments skipped due to low confidence (2)

src/TokenizerBuilder.js:33

  • The error message could be clearer. Suggest changing to: Invalid value for nodeOrBrowser: ${node_or_browser}. Expected 'node' or 'browser'.
throw new Error(`nodeOrBrowser must be 'node' or 'browser': ${node_or_browser}`);

src/TokenizerBuilder.js:31

  • Ensure that there is a test case covering the scenario where an invalid value is provided for nodeOrBrowser.
if (node_or_browser != "node" && node_or_browser != "browser") {
@Hiroshiba
Copy link
Member Author

たぶん大丈夫なのでマージします!

@Hiroshiba Hiroshiba merged commit 0e8d670 into master Dec 15, 2024
2 checks passed
@Hiroshiba Hiroshiba deleted the すべてを書き換えうr branch December 15, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant