Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create creator objects like mia.creator.image.threshold #45

Open
stevevanhooser opened this issue Nov 19, 2021 · 1 comment
Open

create creator objects like mia.creator.image.threshold #45

stevevanhooser opened this issue Nov 19, 2021 · 1 comment
Assignees

Comments

@stevevanhooser
Copy link
Contributor

Hi Katherine -

Can you please create some more creator objects in the style of mia.creator.image.threshold ?

You could do this for the at_image/at_image_process/at_image*.m files first. mia.creator.image.threshold is a re-creation of at_image/at_image_process/at_image_threshold.m and it is an example to follow.

Thanks!
Steve

@stevevanhooser
Copy link
Contributor Author

Hi Katherine -

I finally got to write the mia.test.creator.roi.connect function

I re-organized the test code a little bit into mia.test instead of mia.testcode and made the function names a little shorter.

Everything looks good, except that we don't need the subpackages "makers" and "editors" anymore. I moved mia.creator.roi.makers.connect -> mia.creator.roi.connect.

Can you please move the editors directly into the mia.creator.roi. package as well please? Does the testing structure make sense? You could go ahead and make other test functions for the other roi objects.

Thanks!
Best
Steve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants