-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrates EDA components in WDK views #1314
base: main
Are you sure you want to change the base?
Conversation
f799868
to
d4b68f8
Compare
65afb12
to
76fd220
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and understood the big picture of extracting useAnalysisState()
from useAnalysis()
😄
Thanks! Happy to answer any questions. |
@asizemore I just pushed some commits that uses an eda scatterplot in the phenotype section of gene pages. I am testing it with a local genomics-site dev server. In
Run Let me know if you have questions. |
fixes #1311 and #1312
This PR integrates EDA components in two WDK contexts:
In the case of the WDK search parameter, we are using a WDK
stringParam
and using a custom React component (EdaSubsettingParameter
) to integrate EDA subsetting in the search page. A process query will take the subset descriptor and use it to request a tabular report of gene IDs from the EDA service.Part of this work required extracting analysis modification code from the
useAnalysis
hook, to prevent synchronization issues related to managing state. There is a new hook calleduseAnalysisState
that theEdaSubsettingParameter
component and theuseAnalysis
hook are both using.TODOs
useAnalysisState
hook fromuseAnalysis
Figure out how to find the correct output entity for subsetting(Assume we can use the root entity, for now. If, in the future, this is not adequate, then we can use a property list in the model to define the output entity).