Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrates EDA components in WDK views #1314

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

Conversation

dmfalke
Copy link
Member

@dmfalke dmfalke commented Jan 22, 2025

fixes #1311 and #1312

This PR integrates EDA components in two WDK contexts:

  • A WDK search parameter that utilized EDA subsetting
  • A WDK record page that utilizes an EDA visualization (scatterplot)

In the case of the WDK search parameter, we are using a WDK stringParam and using a custom React component (EdaSubsettingParameter) to integrate EDA subsetting in the search page. A process query will take the subset descriptor and use it to request a tabular report of gene IDs from the EDA service.

Part of this work required extracting analysis modification code from the useAnalysis hook, to prevent synchronization issues related to managing state. There is a new hook called useAnalysisState that the EdaSubsettingParameter component and the useAnalysis hook are both using.


TODOs

  • Extract useAnalysisState hook from useAnalysis
  • Hide starred variable UI
  • Simplify EDA Workspace context provisioning
  • Use global memoization for client api modules
  • Figure out how to find the correct output entity for subsetting (Assume we can use the root entity, for now. If, in the future, this is not adequate, then we can use a property list in the model to define the output entity).

Copy link
Member

@bobular bobular left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and understood the big picture of extracting useAnalysisState() from useAnalysis() 😄

@dmfalke
Copy link
Member Author

dmfalke commented Feb 6, 2025

Reviewed and understood the big picture of extracting useAnalysisState() from useAnalysis() 😄

Thanks! Happy to answer any questions.

@dmfalke
Copy link
Member Author

dmfalke commented Feb 6, 2025

@asizemore I just pushed some commits that uses an eda scatterplot in the phenotype section of gene pages.

I am testing it with a local genomics-site dev server.

In packages/sites/genomics-site/.env:

BASE_PROXY_URL=https://qa.toxodb.org
LEGACY_WEB_APP_URL=${BASE_PROXY_URL}/toxo
PROJECT_ID=ToxoDB

Run yarn nx start @veupathdb/genomics-site and navigate to http://localhost:8080/a/app/record/gene/TGGT1_261490#category:phenomics.

Let me know if you have questions.

@dmfalke dmfalke closed this Feb 11, 2025
@dmfalke dmfalke deleted the eda-in-wdk/search branch February 11, 2025 18:44
@dmfalke dmfalke restored the eda-in-wdk/search branch February 11, 2025 18:46
@dmfalke dmfalke reopened this Feb 11, 2025
@dmfalke dmfalke changed the title Use eda subsetting as a wdk search parameter Integrates EDA components in WDK views Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WDK Search - Add an EDAParameter type
2 participants