Merge remote-tracking branch 'origin/orthogroup-tree-table' into orth…

…ogroup-tree-table__1254-fixes
VEuPathDB · Nov 1, 2024 · 494e55d · 494e55d
2 parents 6907790 + 5bd7d1c
commit 494e55d
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/packages/libs/coreui/src/components/buttons/PopoverButton/PopoverButton.tsx b/packages/libs/coreui/src/components/buttons/PopoverButton/PopoverButton.tsx
@@ -5,6 +5,7 @@ import {
   useMemo,
   forwardRef,
   useImperativeHandle,
+  useCallback,
 } from 'react';
 import { Popover } from '@material-ui/core';
 import SwissArmyButton from '../SwissArmyButton';
@@ -117,15 +118,19 @@ const PopoverButton = forwardRef<PopoverButtonHandle, PopoverButtonProps>(
       [styleOverrides]
     );
 
-    const onCloseHandler = () => {
+    const onCloseHandler = useCallback(() => {
       setAnchorEl(null);
       onClose && onClose();
-    };
+    }, [onClose]);
 
     // Expose the `close()` method to external components via ref
-    useImperativeHandle(ref, () => ({
-      close: onCloseHandler,
-    }));
+    useImperativeHandle(
+      ref,
+      () => ({
+        close: onCloseHandler,
+      }),
+      [onCloseHandler]
+    );
 
     useEffect(() => {
       if (!setIsPopoverOpen) return;