Fix race condition in status job status checking #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foxcapades
reviewed
Jan 10, 2024
| import java.util.concurrent.locks.ReentrantLock | ||
| import kotlin.concurrent.withLock | ||
|
|
||
| internal object JobManager { | ||
| private val lock = ReentrantLock() | ||
| private val Log = LoggerFactory.getLogger(javaClass) | ||
| private val LocksByJobID = ConcurrentHashMap<String, ReentrantLock>() |
There was a problem hiding this comment.
Where are entries in this map removed?
There was a problem hiding this comment.
Updated to use a library based on Guava's cache that will auto-expire entries. It seems to be pretty well-maintained and is relatively light-weight.
Foxcapades
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR Checklist