[Vacgom-142] 아기 삭제 API 구현 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
🎋 Issue Ticket
🔑 주요 작업사항
🏞 (Optional) 참고 자료
(중요) 서브모듈이 수정되었나요?
꼭 확인해 주세요!!
현재 cascade를 설정해 뒀습니다! 다만, 현재는 cascade를 위해 불필요하게 @onetomany를 추가해 놓은 상황이에요!
BabyCommandService에서 아기 관련 데이터 서비스 클래스들을 의존관계를 맺고 일일이 삭제할까 하다가 당장 다른 서비스 클래스들의 의존관계를 맺는 것보단 양방향 매핑의 장점과 cascade로 한 번에 삭제가 가능하다는 점이 더 편리할 것이라 생각했고, 추후 해당 서비스 클래스들이 다른 곳에서도 사용될 필요가 있다면 의존 관계를 맺는 쪽으로 리팩토링 할 의도로 다음과 같이 구현했습니다! 이 부분에 대해서 해빈님 생각은 어떠하신지 궁금합니다!