Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added in code for dynamic custom routes #90

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Conversation

iyasinn
Copy link
Contributor

@iyasinn iyasinn commented Jan 18, 2024

Status

READY

Description

This PR adds in a new catch-all [...slug].tsx route that takes a given route to v1michigan.com and determines if we've created any name->link pairs in supabase for it. If it doesn't exist then we redirect to the 404 error page.
Given this new functionality, removed the join.tsx and apply.tsx files.

Copy link

netlify bot commented Jan 18, 2024

Deploy Preview for v1-platform ready!

Name Link
🔨 Latest commit 739712e
🔍 Latest deploy log https://app.netlify.com/sites/v1-platform/deploys/65b8431487dd7e0008ef9ec1
😎 Deploy Preview https://deploy-preview-90--v1-platform.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@iyasinn iyasinn temporarily deployed to Platform (Supabase) January 18, 2024 05:22 — with GitHub Actions Inactive
@iyasinn iyasinn temporarily deployed to Platform (Supabase) January 18, 2024 22:04 — with GitHub Actions Inactive
@iyasinn
Copy link
Contributor Author

iyasinn commented Jan 18, 2024

Added support for routes like foo1/foo2.

Deleted the team, team/index.tsx, and team/apply.tsx, and added the routes to supabase!

@iyasinn iyasinn temporarily deployed to Platform (Supabase) January 30, 2024 00:30 — with GitHub Actions Inactive
Copy link
Contributor

@HariChidam HariChidam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iyasinn iyasinn merged commit 739712e into master Jan 31, 2024
5 of 9 checks passed
@iyasinn iyasinn deleted the dynamic-custom-routes branch January 31, 2024 00:51
@iyasinn iyasinn temporarily deployed to Platform (Supabase) January 31, 2024 00:51 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants