YDA-6059 fix datarequest api tests #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FuHsinyu
changed the title
In iRODS 4.3+, users can now only modify file ownership if they are the owner or have stronger rights (like admin). Previously, users with only read permission could change ownership. For more details, see irods/irods#6579.
lwesterhof
force-pushed
the
YDA-6059-fix-datarequest-api-tests
branch
from
d9b2973 to
a4adace
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause analysis:
In irods, previously, the user can modify the ownership of the file without being the owner (the user may only have read-permission). but now, the user can only modify the ownership of the file, if they are the owner (or stronger rights like admin). For more discussion, see irods/irods#6579
What were done:
Note, in case you encountered the ReadTimeOut from HTTPConnectionPool, while running API tests. Try to update the timeout of HTTPConnectionPool, e.g, /yoda/yoda-ruleset/tests/venv_pytest/lib/python3.8/site-packages/urllib3/connectionpool.py in the function: _make_request()