Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YDA-4101: Ability to add external user on behalf of another user #5

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

claravox
Copy link
Contributor

@claravox claravox commented Oct 5, 2023

Copy link
Member

@stsnel stsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general 👍 , I have added two comments

yclienttools/importgroups.py Show resolved Hide resolved
@@ -379,6 +386,10 @@ def _get_args():
help='Show information as extracted from CSV file')
parser.add_argument('--no-validate-domains', '-n', action='store_true',
help='Do not validate email address domains')
parser.add_argument('--creator-user', type=str,
help='User who creates user')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a note to the help text of these arguments that they're only available for Yoda 1.9 and higher?

Copy link
Member

@stsnel stsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM 👍

@claravox claravox merged commit c31f60a into master Oct 10, 2023
@claravox claravox deleted the YDA-4101-create-external-user-behalf branch October 10, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants