chore: fix linting

playbooks/irods_server.yml

@@ -3,7 +3,7 @@
   hosts: localhost
   gather_facts: true
 
-  # irods server will use a local postgresql database   
+  # irods server will use a local postgresql database
 
   roles:
     - irods_server

playbooks/roles/agisoft/tasks/main.yml

@@ -11,6 +11,7 @@
   ansible.builtin.file:
     path: "{{ agisoft_download_dest }}"
     state: directory
+    mode: "0755"
 
 - name: Download agisoft installation files
   ansible.builtin.get_url:
@@ -29,6 +30,7 @@
   ansible.builtin.copy:
     dest: "{{ agisoft_install_dir }}/license.lic"
     content: "{{ license }}"
+    mode: "0644"
 
 - name: Install desktop file menu item through role
   ansible.builtin.include_role:

playbooks/roles/anaconda/tasks/dependencies_yum.yml

@@ -1,6 +1,6 @@
 ---
 - name: Install dependencies
-  ansible.builtin.yum:
+  ansible.builtin.dnf:
     name:
       - libXcomposite
       - libXcursor

playbooks/roles/anaconda/tasks/main.yml

@@ -3,10 +3,12 @@
 ---
 - name: Install dependencies
   ansible.builtin.include_tasks: dependencies_{{ ansible_pkg_mgr }}.yml
+
 - name: Ensure download dir exists
   ansible.builtin.file:
     path: "{{ anaconda_download_dest }}"
     state: directory
+    mode: "0750"
 
 - name: Add users to anaconda multiple user group by default
   ansible.builtin.include_role:

playbooks/roles/camunda_modeler/tasks/main.yml

@@ -8,6 +8,7 @@
   ansible.builtin.get_url:
     url: "{{ camunda_modeler_urldir }}/{{ camunda_modeler_urlfile_prefix }}.tar.gz"
     dest: /tmp/{{ camunda_modeler_urlfile_prefix }}.tar.gz
+    mode: "0640"
 
 - name: Unpack modeler tar.gz file in tmp location
   ansible.builtin.unarchive:

playbooks/roles/camunda_server/tasks/main.yml

@@ -30,12 +30,14 @@
     src: "{{ camunda_tomcatdir }}/conf/bpm-platform.xml"
     remote_src: true
     dest: "{{ catalina_home }}/conf/bpm-platform.xml"
+    mode: "0644"
 
 - name: Copy camunda jars to tomcat lib
   ansible.builtin.copy:
     src: "{{ camunda_dir }}/lib/"
     remote_src: true
     dest: "{{ catalina_home }}/lib/"
+    mode: "0644"
 
 # a copy with remore_src preserves file attribs regardless of mode
 # hence we need to set these props using a separate command

playbooks/roles/desktop_file/tasks/main.yml

@@ -2,10 +2,12 @@
 - name: Check if required variables are present
   when: (desktopfile_app_name is not defined) or (desktopfile_sizes is not defined)
   ansible.builtin.meta: end_play
+
 - name: Preventing bug - Ensure directory exists
   ansible.builtin.file:
     path: /usr/share/desktop-directories/
     state: directory
+    mode: "0755"
 
 - name: Install xdg utilities
   ansible.builtin.package:

playbooks/roles/fact_regular_users/molecule/default/prepare.yml

@@ -8,6 +8,7 @@
         dest: /etc/rsc/managedgroups
         content: >
           src_ws_admin
+        mode: "0644"
 
     - name: Ensure group "src_ws_admin" exists
       ansible.builtin.group:

playbooks/roles/install_role/molecule/default/prepare.yml

@@ -7,6 +7,7 @@
       ansible.builtin.file:
         dest: /rsc/roles
         state: directory
+        mode: "0755"
 
     - name: Copy the role to the workspace
       ansible.posix.synchronize:
@@ -19,6 +20,7 @@
     - name: Copy test playbook to the workspace
       ansible.builtin.copy:
         dest: /rsc/test.yml
+        mode: "0644"
         content: |
           - name: Test dependency installation
             hosts: localhost

playbooks/roles/irods_repo/tasks/main.yml

@@ -14,6 +14,7 @@
   ansible.builtin.get_url:
     url: "{{ irods_repo_url }}/irods-signing-key.asc"
     dest: "{{ irods_key_location }}"
+    mode: "0644"
   when: ansible_pkg_mgr == 'apt'
 
 - name: Add iRODS repository for apt package manager

playbooks/roles/keycloak/tasks/main.yml

@@ -20,6 +20,7 @@
   ansible.builtin.get_url:
     url: "{{ keycloak_tardir }}{{ keycloak_tarfile }}"
     dest: "{{ keycloak_dir }}"
+    mode: "0644"
 
 - name: Extract keycloak tar
   ansible.builtin.unarchive:

playbooks/roles/nginx_uwsgi/molecule/_prepare.yml

@@ -4,9 +4,10 @@
     update_cache: true
 
 - name: Create uwsgi dir
-  file:
+  ansible.builtin.file:
     path: /var/www/uwsgi
     state: directory
+    mode: "0750"
 
 - name: Add uwsgi test app
   ansible.builtin.copy:

playbooks/roles/nginx_uwsgi/tasks/main.yml

@@ -85,6 +85,7 @@
         copytruncate
       }
     create: true
+    mode: "0644"
 
 - name: Start app service
   ansible.builtin.systemd_service:

playbooks/roles/pipx_install_systemwide/tasks/main.yml

@@ -12,6 +12,7 @@
   when: pipx_install_systemwide_profile | length > 0
   ansible.builtin.copy:
     dest: /etc/profile.d/{{ pipx_install_systemwide_profile }}
+    mode: "0644"
     content: |
       export PATH="{{ pipx_install_systemwide_location }}/bin${PATH:+:${PATH}}"
 

playbooks/roles/rstudio/tasks/redhat.yml

@@ -2,7 +2,7 @@
 - name: Update extra packages
   ansible.builtin.package:
     name: epel-release
-    state: latest
+    state: present
 
 - name: Install R
   ansible.builtin.package:

playbooks/roles/security_updates/tasks/main.yml

@@ -42,6 +42,7 @@
       ansible.builtin.template:
         src: upgrade-bootstrap.timer
         dest: /etc/systemd/system/upgrade-bootstrap.timer
+        mode: "0644"
 
     - name: Enable bootstrap timer
       ansible.builtin.command: "{{ item }}"

playbooks/roles/sshfs_mount/tasks/main.yml

@@ -9,6 +9,7 @@
     path: "{{ sshfs_connection_info.mountpoint }}"
     state: directory
     owner: "{{ sshfs_connection_info.username }}"
+    mode: "0755"
 
 - name: Enable user_allow_other in fuse config
   tags: molecule-idempotence-notest

playbooks/roles/stata18/molecule/default/prepare.yml

@@ -21,15 +21,18 @@
       ansible.builtin.copy:
         dest: /tmp/unix/linux64/setrwxp
         content: mock
+        mode: "0755"
 
     - name: Create mock stata archive1
       ansible.builtin.command:
         cmd: tar -cvzf unix/linux64/test.taz /etc/hosts # any random file
         creates: /tmp/unix/linux64/test.taz
         chdir: /tmp
+        mode: "0755"
 
     - name: Create mock stata archive2
       ansible.builtin.command:
         cmd: tar -cvzf /home/uurobot/remote-data/stata/stata18-linux/Stata18Linux64.tar.gz unix
         creates: /home/uurobot/remote-data/stata/stata18-linux/Stata18Linux64.tar.gz
         chdir: /tmp
+        mode: "0755"