Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save table prediction in cells format #335

Merged
merged 8 commits into from
Apr 22, 2024
Merged

Save table prediction in cells format #335

merged 8 commits into from
Apr 22, 2024

Conversation

plutasnyy
Copy link
Contributor

This pull request allows to return predictions in raw cell representation from table transformer. It will be later used in unstructured repository to save prediction in a cells format for simpler metrics calculation

@plutasnyy plutasnyy requested a review from badGarnet April 15, 2024 16:45
@plutasnyy plutasnyy self-assigned this Apr 15, 2024
Copy link
Collaborator

@badGarnet badGarnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • please add a test
  • and bump version

@plutasnyy
Copy link
Contributor Author

For the unit tests:

Bumping version:

  • Last released version is 0.7.25, the change-log was edited for 0.7.26. Is there any script to bump version you referring to? How can I bump version?

Not passing test_ingest:

  • @badGarnet could you guide me how to debug this problem? I looked into logs and I do not see any stacktrace and errors

@badGarnet
Copy link
Collaborator

For the unit tests:

Bumping version:

  • Last released version is 0.7.25, the change-log was edited for 0.7.26. Is there any script to bump version you referring to? How can I bump version?

Not passing test_ingest:

  • @badGarnet could you guide me how to debug this problem? I looked into logs and I do not see any stacktrace and errors

the version bump is just edit both the CHANGLOG.md and unstructured_inference/__version__.py to match. We could add a ci lint check to ensure those two are consistent.

The ingest test failing can be ignored for now (it is not required anyway); we should take a look and maybe remove this step as it has been out of date for a while.

@plutasnyy
Copy link
Contributor Author

plutasnyy commented Apr 17, 2024

The version in __version__ file is also one number higher than last released version, so I assume it should be correct?

Files for reference:
https://github.com/Unstructured-IO/unstructured-inference/blob/feat/table-as-cells/unstructured_inference/__version__.py
https://github.com/Unstructured-IO/unstructured-inference/blob/feat/table-as-cells/CHANGELOG.md

@plutasnyy plutasnyy merged commit 4304c83 into main Apr 22, 2024
5 of 7 checks passed
@plutasnyy plutasnyy deleted the feat/table-as-cells branch April 22, 2024 10:46
github-merge-queue bot pushed a commit to Unstructured-IO/unstructured that referenced this pull request Apr 25, 2024
This pull request allows to return predictions in raw cell
representation from table transformer. It will be later used to save
prediction in a cells format for simpler metrics calculation.

This PR has to be merged, after
Unstructured-IO/unstructured-inference#335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants