Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: wrong label map key type #322

Merged
merged 4 commits into from
Mar 18, 2024
Merged

Fix: wrong label map key type #322

merged 4 commits into from
Mar 18, 2024

Conversation

erjieyong
Copy link
Contributor

When reading the json file via UNSTRUCTURED_DEFAULT_MODEL_INITIALIZE_PARAMS_JSON_PATH environment variable, the label_map keys have to be converted to int type before it can be referenced. Added code to always convert label_map keys to int type.

@cragwolfe cragwolfe requested review from qued and badGarnet February 18, 2024 01:42
qued
qued approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@qued qued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I see some formatting changes, which makes me think the formatting settings are different, but I think we can fix that in a follow-up PR.

@qued qued enabled auto-merge (squash) March 18, 2024 15:49
@qued qued disabled auto-merge March 18, 2024 15:50
@qued qued merged commit 935f610 into Unstructured-IO:main Mar 18, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qued qued qued approved these changes

@badGarnet badGarnet Awaiting requested review from badGarnet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erjieyong @qued