Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to allow MITM capability to be given #6

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Proposal to allow MITM capability to be given #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c91276
Capability proposal
jfberry Apr 14, 2024
8a44c7e
Change new capability to bool; add some comments
jfberry Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions rotom.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@ message MitmRequest {
LoginSource source = 2;
bytes token_proto = 3;
string worker_id = 4;
bool enable_compression = 5;
bool enable_compression = 5; // Controller can support compressed responses
}

message RpcRequest {
message SingleRpcRequest {
int32 method = 1;
bytes payload = 2;
bool is_compressed = 3;
bool is_compressed = 3; // This request is compressed
}

repeated SingleRpcRequest request = 1;
Expand Down Expand Up @@ -60,15 +60,16 @@ message MitmResponse {
message LoginResponse {
string worker_id = 1;
AuthStatus status = 2;
bool supports_compression = 3;
bool supports_compression = 3; // Agent can support compressed requests
string useragent = 4;
bool request_long_sessions = 5; // Agent prefers longer sessions over fast reconnects
}

message RpcResponse {
message SingleRpcResponse {
int32 method = 1;
bytes payload = 2;
bool is_compressed = 3;
bool is_compressed = 3; // This payload response is compressed
}

RpcStatus rpc_status = 1;
Expand Down