Dynamic page title fix using context Api #705
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtucholski
requested review from
jtucholski
and removed request for
jtucholski
|
@corypride Taking a look at this today. Was there a decision that was made to go in a different direction from what we had considered a week ago? |
|
@corypride Are you referring to a different PR? This PR is for the refactored page title fix. |
jtucholski
requested changes
Feb 4, 2025
There was a problem hiding this comment.
Looks good. I think the added context threw me off from the initial approach we discussed but I believe that what you did is the proper way to implement and share data between components.
I've requested two changes to remove some comments that seem unnecessary.
PThorpe92
force-pushed
the
dynamic-page-titles-contextApi
branch
from
1ebc705 to
abd4d5b
Compare
PThorpe92
reviewed
Feb 6, 2025
| AuthLayoutPageTitleProviderProps | ||
| > = ({ children }) => { | ||
| const [authLayoutPageTitle, setAuthLayoutPageTitle] = | ||
| useState<string>('Library Viewer'); |
There was a problem hiding this comment.
Library Viewer is the default option here?
There was a problem hiding this comment.
What are we suggesting here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Lifted state from the PageNav component to AuthenticatedLayout using the context Api and therefore giving access to all wrapped in the provider the ability to call and SetAuthLayoutPageTitle to dynamically set the pageTitle.
Screenshot(s)
dynamicPageTitlesContextApi.mp4