Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add query context to database cleanup handlers #696

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

refactor: add query context to database cleanup handlers #696

wants to merge 4 commits into from

Conversation

PThorpe92
Copy link
Member

#694

This does some significant cleanup to the handler/DB API

@PThorpe92 PThorpe92 force-pushed the query_context branch 3 times, most recently from 807bf3b to 6c116d1 Compare January 30, 2025 22:19
carddev81
carddev81 requested changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@carddev81 carddev81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff man! This cleaned up a lot and makes coding handlers faster for sure! Made some comments on my findings.

backend/src/handlers/fields.go Outdated Show resolved Hide resolved
backend/src/database/libraries.go Show resolved Hide resolved
backend/src/database/libraries.go Show resolved Hide resolved
backend/src/database/courses.go Outdated Show resolved Hide resolved
backend/src/database/libraries.go Show resolved Hide resolved
backend/src/database/programs.go Outdated Show resolved Hide resolved
backend/src/database/provider_platforms.go Outdated Show resolved Hide resolved
backend/src/database/provider_user_mappings.go Outdated Show resolved Hide resolved
backend/src/database/videos.go Outdated Show resolved Hide resolved
backend/src/handlers/libraries_handler.go Show resolved Hide resolved
@PThorpe92 PThorpe92 requested a review from carddev81 February 3, 2025 21:04
@jtucholski jtucholski linked an issue Feb 7, 2025 that may be closed by this pull request
Implement Hook to clean up how query parameters are added to frontend API calls #706
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carddev81 carddev81 Awaiting requested review from carddev81

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Backend CronTasks frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Hook to clean up how query parameters are added to frontend API calls
2 participants
@PThorpe92 @carddev81